turn it on!

Author: nhsd-david-wass

lambdas/supplier-allocator/src/handler/allocate-handler.ts

@@ -61,7 +61,7 @@ function validateType(event: unknown) {
 async function getSupplierFromConfig(
   letterEvent: PreparedEvents,
   deps: Deps,
-): Promise<SupplierDetails | undefined> {
+): Promise<SupplierDetails> {
   try {
     const letterVariant: LetterVariant = await getVariantDetails(
       letterEvent.data.letterVariantId,
@@ -129,12 +129,12 @@ async function getSupplierFromConfig(
     };
     return supplierDetails;
   } catch (error) {
-    deps.logger.info({
+    deps.logger.error({
       description: "Error fetching supplier from config",
       err: error,
       variantId: letterEvent.data.letterVariantId,
     });
-    return undefined;
+    throw error;
   }
 }
 
@@ -232,11 +232,12 @@ export default function createSupplierAllocatorHandler(deps: Deps): SQSHandler {
 
         validateType(letterEvent);
 
-        const supplierSpec = getSupplier(letterEvent as PreparedEvents, deps);
-        const supplierDetails = await getSupplierFromConfig(
+        getSupplier(letterEvent as PreparedEvents, deps);
+        const supplierDetails: SupplierDetails = await getSupplierFromConfig(
           letterEvent as PreparedEvents,
           deps,
         );
+        const supplierSpec = supplierDetails?.supplierSpec;
 
         deps.logger.info({
           description: "Resolved supplier details from config",