handle non existent overall allocations

Author: nhsd-david-wass

internal/datastore/src/supplier-quotas-repository.ts

@@ -33,17 +33,17 @@ export class SupplierQuotasRepository {
     readonly config: SupplierQuotasRepositoryConfig,
   ) {}
 
-  async getOverallAllocation(groupId: string): Promise<OverallAllocation> {
+  async getOverallAllocation(
+    groupId: string,
+  ): Promise<OverallAllocation | undefined> {
     const result = await this.ddbClient.send(
       new GetCommand({
         TableName: this.config.supplierQuotasTableName,
         Key: { pk: "ENTITY#overall-allocation", sk: `ID#${groupId}` },
       }),
     );
     if (!result.Item) {
-      throw new Error(
-        `No overall allocation found for volume group id ${groupId}`,
-      );
+      return undefined;
     }
     return $OverallAllocation.parse(result.Item);
   }
@@ -69,7 +69,10 @@ export class SupplierQuotasRepository {
     newAllocation: number,
   ): Promise<void> {
     const overallAllocation = await this.getOverallAllocation(groupId);
-    const currentAllocation = overallAllocation.allocations[supplierId] ?? 0;
+    const allocations = overallAllocation?.allocations ?? {};
+    const currentAllocation = Object.hasOwn(allocations, supplierId)
+      ? allocations[supplierId]
+      : 0;
     const updatedAllocation = currentAllocation + newAllocation;
 
     await this.ddbClient.send(

lambdas/supplier-allocator/src/services/supplier-quotas.ts

@@ -7,9 +7,16 @@ export async function calculateSupplierAllocatedFactor(
   deps: Deps,
 ): Promise<{ supplierId: string; factor: number }[]> {
   const volumeGroupId = supplierAllocations[0].volumeGroup; // Assuming all allocations are for the same volume group
-  const overallAllocation: OverallAllocation =
+  const overallAllocation =
     await deps.supplierQuotasRepo.getOverallAllocation(volumeGroupId);
 
+  if (!overallAllocation) {
+    return supplierAllocations.map((allocation) => ({
+      supplierId: allocation.supplier,
+      factor: 0,
+    }));
+  }
+
   const { allocations } = overallAllocation;
 
   const totalAllocation = Object.values(allocations).reduce(
@@ -35,15 +42,25 @@ export async function updateSupplierQuota(
   const overallAllocation =
     await deps.supplierQuotasRepo.getOverallAllocation(groupId);
 
-  const updatedAllocations = {
-    ...overallAllocation.allocations,
-    [supplierId]: newAllocation,
-  };
+  const updatedAllocations = overallAllocation
+    ? {
+        ...overallAllocation.allocations,
+        [supplierId]: newAllocation,
+      }
+    : {
+        [supplierId]: newAllocation,
+      };
 
-  const updatedOverallAllocation: OverallAllocation = {
-    ...overallAllocation,
-    allocations: updatedAllocations,
-  };
+  const updatedOverallAllocation: OverallAllocation = overallAllocation
+    ? {
+        ...overallAllocation,
+        allocations: updatedAllocations,
+      }
+    : {
+        id: groupId,
+        volumeGroup: groupId,
+        allocations: updatedAllocations,
+      };
 
   await deps.supplierQuotasRepo.putOverallAllocation(updatedOverallAllocation);
 }