CCM-11938: Fix sonar issues

Author: sidnhs

.github/actions/build-proxies/action.yml

@@ -81,6 +81,11 @@ runs:
           echo "Building env specific OAS spec"
           make build-json-oas-spec APIM_ENV=${{ inputs.apimEnv }}
         fi
+        if [[ $APIM_ENV == *-pr ]]; then
+          echo "Removing pr suffix from APIM_ENV after building OAS and calling proxygen"
+          APIM_ENV=$(echo "$APIM_ENV" | sed 's/-pr$//')
+          echo "APIM_ENV=$APIM_ENV" >> $GITHUB_ENV
+        fi
 
     - name: Upload OAS Spec
       uses: actions/upload-artifact@v4

.github/workflows/manual-proxy-environment-deploy.yaml

@@ -70,18 +70,15 @@ jobs:
 
           echo "ENVIRONMENT=$ENVIRONMENT" >> $GITHUB_ENV
           echo "APIM_ENV=$APIM_ENV" >> $GITHUB_ENV
-      - name: Build environment oas
-        working-directory: .
-        env:
-          APIM_ENV: ${{ env.APIM_ENV }}
-        shell: bash
-        run: |
-            make build-json-oas-spec APIM_ENV=$APIM_ENV
-            if [[ $APIM_ENV == *-pr ]]; then
-              echo "Removing pr suffix from APIM_ENV after building OAS and calling proxygen"
-              APIM_ENV=$(echo "$APIM_ENV" | sed 's/-pr$//')
-              echo "APIM_ENV=$APIM_ENV" >> $GITHUB_ENV
-            fi
+      # - name: Build environment oas
+      #   working-directory: .
+      #   env:
+      #     APIM_ENV: ${{ env.APIM_ENV }}
+      #   shell: bash
+      #   run: |
+      #       make build-json-oas-spec APIM_ENV=$APIM_ENV
+            
+      #       fi
       - name: "Build proxies"
         env:
           PROXYGEN_API_NAME: nhs-notify-supplier