fix error enum

Author: RossFaulds171

lambdas/api-handler/src/contracts/errors.ts

@@ -28,8 +28,7 @@ export enum ApiErrorStatus {
 }
 
 export enum ApiErrorDetail {
-  NotFoundLetterId = "No resource found with that ID",
-  NotFoundMiId = "No resource found with that ID",
+  NotFoundId = "No resource found with that ID",
   InvalidRequestMissingBody = "The request is missing the body",
   InvalidRequestMissingLetterIdPathParameter = "The request is missing the letter id path parameter",
   InvalidRequestLetterIdsMismatch = "The letter ID in the request body does not match the letter ID path parameter",

lambdas/api-handler/src/handlers/__tests__/get-letter.test.ts

@@ -120,7 +120,7 @@ describe("API Lambda handler", () => {
   it("returns 404 Not Found when letter matching id is not found", async () => {
     const mockedGetLetterById = letterService.getLetterById as jest.Mock;
     mockedGetLetterById.mockImplementation(() => {
-      throw new NotFoundError(ApiErrorDetail.NotFoundLetterId);
+      throw new NotFoundError(ApiErrorDetail.NotFoundId);
     });
 
     const event = makeApiGwEvent({

lambdas/api-handler/src/handlers/__tests__/get-mi.test.ts

@@ -83,7 +83,7 @@ describe("API Lambda handler", () => {
     const mockedGetMiById = getMiOperation as jest.Mock;
 
     mockedGetMiById.mockImplementation(() => {
-      throw new NotFoundError(ApiErrorDetail.NotFoundMiId);
+      throw new NotFoundError(ApiErrorDetail.NotFoundId);
     });
 
     const event = makeApiGwEvent({

lambdas/api-handler/src/mappers/__tests__/error-mapper.test.ts

@@ -35,7 +35,7 @@ describe("processError", () => {
   });
 
   it("should map NotFoundError to NotFound response", () => {
-    const err = new NotFoundError(ApiErrorDetail.NotFoundLetterId);
+    const err = new NotFoundError(ApiErrorDetail.NotFoundId);
 
     const res = processError(err, undefined, {
       info: jest.fn(),

lambdas/api-handler/src/services/letter-operations.ts

@@ -51,7 +51,7 @@ export const getLetterById = async (
     letter = await letterRepo.getLetterById(supplierId, letterId);
   } catch (error) {
     if (isNotFoundError(error)) {
-      throw new NotFoundError(ApiErrorDetail.NotFoundLetterId);
+      throw new NotFoundError(ApiErrorDetail.NotFoundId);
     }
     throw error;
   }
@@ -75,7 +75,7 @@ export const getLetterDataUrl = async (
     );
   } catch (error) {
     if (isNotFoundError(error)) {
-      throw new NotFoundError(ApiErrorDetail.NotFoundLetterId);
+      throw new NotFoundError(ApiErrorDetail.NotFoundId);
     }
     throw error;
   }