update test utility

Author: nhsd-david-wass

internal/datastore/src/__test__/letter-repository.test.ts

@@ -30,7 +30,7 @@ function createLetter(
     source: "/data-plane/letter-rendering/pdf",
     subject: `client/1/letter-request/${letterId}`,
     billingRef: "specification1",
-    specificationBillingId: "specification1",
+    specificationBillingId: "billing1",
   };
 }
 

scripts/utilities/letter-test-data/README.md

@@ -16,6 +16,7 @@ npm run cli -- create-letter \
   --letter-id letter-id \
   --group-id group-id \
   --specification-id specification-id \
+  --billing-id billing-id \
   --status PENDING
 ```
 
@@ -26,6 +27,7 @@ npm run cli -- create-letter-batch \
   --awsAccountId 820178564574 \
   --group-id group-id \
   --specification-id specification-id \
+  --billing-id billing-id \
   --status PENDING \
   --count 10
 ```

scripts/utilities/letter-test-data/src/__test__/helpers/create-letter-helpers.test.ts

@@ -29,6 +29,7 @@ describe("Create letter helpers", () => {
     const targetFilename = "targetFilename";
     const groupId = "groupId";
     const specificationId = "specificationId";
+    const billingId = "billingId";
     const status = "PENDING" as LetterStatusType;
     const testLetter = "test-letter-standard";
 
@@ -39,6 +40,7 @@ describe("Create letter helpers", () => {
       targetFilename,
       groupId,
       specificationId,
+      billingId,
       status,
       letterRepository: mockedLetterRepository,
       testLetter,
@@ -62,7 +64,7 @@ describe("Create letter helpers", () => {
       source: "/data-plane/letter-rendering/letter-test-data",
       subject: "supplier-api/letter-test-data/letterId",
       billingRef: "specificationId",
-      specificationBillingId: "specificationId",
+      specificationBillingId: "billingId",
     });
   });
 
@@ -82,6 +84,7 @@ describe("Create letter helpers", () => {
     const targetFilename = "targetFilename";
     const groupId = "groupId";
     const specificationId = "specificationId";
+    const billingId = "billingId";
     const status = "PENDING" as LetterStatusType;
     const testLetter = "none";
 
@@ -92,6 +95,7 @@ describe("Create letter helpers", () => {
       targetFilename,
       groupId,
       specificationId,
+      billingId,
       status,
       letterRepository: mockedLetterRepository,
       testLetter,
@@ -111,7 +115,7 @@ describe("Create letter helpers", () => {
       billingRef: "specificationId",
       source: "/data-plane/letter-rendering/letter-test-data",
       subject: "supplier-api/letter-test-data/letterId",
-      specificationBillingId: "specificationId",
+      specificationBillingId: "billingId",
     });
   });
 
@@ -123,6 +127,7 @@ describe("Create letter helpers", () => {
       letterId: "testLetterId",
       supplierId: "testSupplierId",
       specificationId: "testSpecId",
+      billingId: "testBillingId",
       groupId: "testGroupId",
       status: "PENDING" as LetterStatusType,
       url: "s3://bucket/testSupplierId/testLetter.pdf",
@@ -142,7 +147,7 @@ describe("Create letter helpers", () => {
       source: "/data-plane/letter-rendering/letter-test-data",
       subject: "supplier-api/letter-test-data/testLetterId",
       billingRef: "testSpecId",
-      specificationBillingId: "testSpecId",
+      specificationBillingId: "testBillingId",
     });
   });
 });

scripts/utilities/letter-test-data/src/cli/index.ts

@@ -44,6 +44,10 @@ async function main() {
           type: "string",
           demandOption: false,
         },
+        "billing-id": {
+          type: "string",
+          demandOption: false,
+        },
         "ttl-hours": {
           type: "number",
           demandOption: false,
@@ -83,6 +87,7 @@ async function main() {
         const targetFilename = `${letterId}.pdf`;
         const groupId = argv.groupId ?? randomUUID();
         const specificationId = argv.specificationId ?? randomUUID();
+        const billingId = argv.billingId ?? randomUUID();
         const { status } = argv;
         const { environment } = argv;
         const { ttlHours } = argv;
@@ -96,6 +101,7 @@ async function main() {
           targetFilename,
           groupId,
           specificationId,
+          billingId,
           status: status as LetterStatusType,
           letterRepository,
           testLetter,
@@ -130,6 +136,10 @@ async function main() {
           type: "string",
           demandOption: false,
         },
+        "billing-id": {
+          type: "string",
+          demandOption: false,
+        },
         "ttl-hours": {
           type: "number",
           demandOption: false,
@@ -174,6 +184,7 @@ async function main() {
         const { supplierId } = argv;
         const groupId = argv.groupId ?? randomUUID();
         const specificationId = argv.specificationId ?? randomUUID();
+        const billingId = argv.billingId ?? randomUUID();
         const { status } = argv;
         const { environment } = argv;
         const { ttlHours } = argv;
@@ -206,6 +217,7 @@ async function main() {
               supplierId,
               groupId,
               specificationId,
+              billingId,
               status: status as LetterStatusType,
               url,
             }),

scripts/utilities/letter-test-data/src/helpers/create-letter-helpers.ts

@@ -11,12 +11,14 @@ export async function createLetter(params: {
   supplierId: string;
   targetFilename: string;
   specificationId: string;
+  billingId: string;
   groupId: string;
   status: LetterStatusType;
   letterRepository: LetterRepository;
   testLetter: string;
 }) {
   const {
+    billingId,
     bucketName,
     groupId,
     letterId,
@@ -49,7 +51,7 @@ export async function createLetter(params: {
     source: "/data-plane/letter-rendering/letter-test-data",
     subject: `supplier-api/letter-test-data/${letterId}`,
     billingRef: specificationId,
-    specificationBillingId: specificationId,
+    specificationBillingId: billingId,
   };
 
   const letterRecord = await letterRepository.putLetter(letter);
@@ -60,12 +62,20 @@ export function createLetterDto(params: {
   letterId: string;
   supplierId: string;
   specificationId: string;
+  billingId: string;
   groupId: string;
   status: LetterStatusType;
   url: string;
 }) {
-  const { groupId, letterId, specificationId, status, supplierId, url } =
-    params;
+  const {
+    billingId,
+    groupId,
+    letterId,
+    specificationId,
+    status,
+    supplierId,
+    url,
+  } = params;
 
   const letter: Omit<Letter, "ttl" | "supplierStatus" | "supplierStatusSk"> = {
     id: letterId,
@@ -79,7 +89,7 @@ export function createLetterDto(params: {
     source: "/data-plane/letter-rendering/letter-test-data",
     subject: `supplier-api/letter-test-data/${letterId}`,
     billingRef: specificationId,
-    specificationBillingId: specificationId,
+    specificationBillingId: billingId,
   };
 
   return letter;