lint fix and improve test coverage

Author: RossFaulds171

internal/datastore/src/__test__/mi-repository.test.ts

@@ -66,9 +66,8 @@ describe("MiRepository", () => {
   });
 
   describe("getMi", () => {
-    it("throws an error when fetching MI information that does not exist", async() => {
-      await expect(
-        miRepository.getMI("XXX", "supplier1"),
+    it("throws an error when fetching MI information that does not exist", async () => {
+      await expect(miRepository.getMI("XXX", "supplier1")
       ).rejects.toThrow(
         "Management Information with id XXX not found for supplier supplier1",
       );

lambdas/api-handler/src/mappers/__tests__/mi-mapper.test.ts

@@ -1,6 +1,6 @@
 import { MIBase } from "@internal/datastore/src";
 import { IncomingMI, PostMIRequest } from "../../contracts/mi";
-import { mapToMI, mapToPostMIResponse } from "../mi-mapper";
+import { mapToGetMIResponse, mapToMI, mapToPostMIResponse } from "../mi-mapper";
 
 describe("mi-mapper", () => {
   it("maps a PostMIRequest to an IncomingMI object", async () => {
@@ -59,4 +59,33 @@ describe("mi-mapper", () => {
       },
     });
   });
+
+  it("maps an internal MIBase object to a GetMIResponse", async () => {
+    const mi: MIBase = {
+      id: "id1",
+      lineItem: "envelope-business-standard",
+      timestamp: "2023-11-17T14:27:51.413Z",
+      quantity: 22,
+      specificationId: "spec1",
+      groupId: "group1",
+      stockRemaining: 20_000,
+    };
+
+    const result = mapToGetMIResponse(mi);
+
+    expect(result).toEqual({
+      data: {
+        id: "id1",
+        type: "ManagementInformation",
+        attributes: {
+          lineItem: "envelope-business-standard",
+          timestamp: "2023-11-17T14:27:51.413Z",
+          quantity: 22,
+          specificationId: "spec1",
+          groupId: "group1",
+          stockRemaining: 20_000,
+        },
+      },
+    });
+  });
 });

lambdas/api-handler/src/services/__tests__/mi-operations.test.ts

@@ -36,4 +36,29 @@ describe("postMI function", () => {
       },
     });
   });
+
+  it("retrieves the MI from the repository", async () => {
+    const persistedMi = { id: "id1", ...incomingMi };
+
+    const mockRepo = {
+      getMI: jest.fn().mockResolvedValue(persistedMi),
+    };
+
+    const result = await getMI("id1", "supplier1" , mockRepo as any);
+
+    expect(result).toEqual({
+      data: {
+        id: "id1",
+        type: "ManagementInformation",
+        attributes: {
+          lineItem: "envelope-business-standard",
+          timestamp: "2023-11-17T14:27:51.413Z",
+          quantity: 22,
+          specificationId: "spec1",
+          groupId: "group1",
+          stockRemaining: 20_000,
+        },
+      },
+    });
+  });
 });