rename NOTIFY_LETTER_NOT_FOUND to NOTIFY_NOT_FOUND

Author: RossFaulds171

lambdas/api-handler/src/contracts/errors.ts

@@ -12,7 +12,7 @@ export interface ApiError {
 export enum ApiErrorCode {
   InternalServerError = "NOTIFY_INTERNAL_SERVER_ERROR",
   InvalidRequest = "NOTIFY_INVALID_REQUEST",
-  NotFound = "NOTIFY_LETTER_NOT_FOUND",
+  NotFound = "NOTIFY_NOT_FOUND",
 }
 
 export enum ApiErrorTitle {

lambdas/api-handler/src/mappers/__tests__/error-mapper.test.ts

@@ -46,7 +46,7 @@ describe("processError", () => {
     expect(JSON.parse(res.body)).toEqual({
       errors: [
         {
-          code: "NOTIFY_LETTER_NOT_FOUND",
+          code: "NOTIFY_NOT_FOUND",
           detail: "No resource found with that ID",
           id: expect.any(String),
           links: {

sandbox/api/openapi.yaml

@@ -1455,7 +1455,7 @@ components:
           enum:
           - NOTIFY_INTERNAL_SERVER_ERROR
           - NOTIFY_INVALID_REQUEST
-          - NOTIFY_LETTER_NOT_FOUND
+          - NOTIFY_NOT_FOUND
           type: string
         links:
           $ref: "#/components/schemas/listLetters_400_response_errors_inner_links"

tests/helpers/common-types.ts

@@ -34,7 +34,7 @@ export function error404ResponseBody(): ErrorMessageBody {
     errors: [
       {
         id: "12345",
-        code: "NOTIFY_LETTER_NOT_FOUND",
+        code: "NOTIFY_NOT_FOUND",
         links: {
           about:
             "https://digital.nhs.uk/developer/api-catalogue/nhs-notify-supplier",