Add wait status to post tests

Author: francisco-videira-nhs

tests/component-tests/apiGateway-tests/testCases/update-multiple-letter-status.ts

@@ -6,6 +6,14 @@ import {
 } from "../../../helpers/common-types";
 import { SupplierApiLetters } from "../../../helpers/generate-fetch-test-data";
 
+export interface LetterUpdateAttributes {
+  status: string;
+  reasonCode?: string;
+  reasonText?: string;
+}
+
+export type LetterUpdatesById = Record<string, LetterUpdateAttributes>;
+
 export function postLettersRequestHeaders(): RequestHeaders {
   return {
     "NHSD-Supplier-ID": SUPPLIERID,
@@ -23,41 +31,14 @@ export function postLettersInvalidRequestHeaders(): RequestHeaders {
 }
 
 export function postValidRequestBody(
-  letters: SupplierApiLetters[],
+  updatesById: LetterUpdatesById,
 ): PostMessageRequestBody {
   return {
-    data: [
-      {
-        type: "Letter",
-        id: letters[0].id,
-        attributes: {
-          status: "ACCEPTED",
-        },
-      },
-      {
-        type: "Letter",
-        id: letters[1].id,
-        attributes: {
-          status: "REJECTED",
-          reasonCode: "R01",
-          reasonText: "Test Reason",
-        },
-      },
-      {
-        type: "Letter",
-        id: letters[2].id,
-        attributes: {
-          status: "PRINTED",
-        },
-      },
-      {
-        type: "Letter",
-        id: letters[3].id,
-        attributes: {
-          status: "CANCELLED",
-        },
-      },
-    ],
+    data: Object.entries(updatesById).map(([id, attributes]) => ({
+      type: "Letter",
+      id,
+      attributes,
+    })),
   };
 }
 

tests/component-tests/apiGateway-tests/update-multiple-letter-status.spec.ts

@@ -14,6 +14,7 @@ import {
 import {
   createTestData,
   getLettersBySupplier,
+  waitForLetterStatus,
 } from "../../helpers/generate-fetch-test-data";
 
 let baseUrl: string;
@@ -35,14 +36,36 @@ test.describe("API Gateway Tests to Verify post Status Endpoint", () => {
     }
 
     const headers = postLettersRequestHeaders();
-    const body = postValidRequestBody(letters);
+    const updatesById = {
+      [letters[0].id]: { status: "ACCEPTED" },
+      [letters[1].id]: {
+        status: "REJECTED",
+        reasonCode: "R01",
+        reasonText: "Test Reason",
+      },
+      [letters[2].id]: { status: "PRINTED" },
+      [letters[3].id]: { status: "CANCELLED" },
+    };
+
+    const body = postValidRequestBody(updatesById);
 
     const response = await request.post(`${baseUrl}/${SUPPLIER_LETTERS}`, {
       headers,
       data: body,
     });
 
     expect(response.status()).toBe(202);
+
+    await Promise.all(
+      Object.entries(updatesById).map(async ([id, attributes]) => {
+        const letter = await waitForLetterStatus(
+          SUPPLIERID,
+          id,
+          attributes.status,
+        );
+        expect(letter.status).toBe(attributes.status);
+      }),
+    );
   });
 
   test(`Post /letters returns 400 if request has invalid status`, async ({
@@ -107,7 +130,16 @@ test.describe("API Gateway Tests to Verify post Status Endpoint", () => {
     }
 
     const headers = postLettersInvalidRequestHeaders();
-    const body = postValidRequestBody(letters);
+    const body = postValidRequestBody({
+      [letters[0].id]: { status: "ACCEPTED" },
+      [letters[1].id]: {
+        status: "REJECTED",
+        reasonCode: "R01",
+        reasonText: "Test Reason",
+      },
+      [letters[2].id]: { status: "PRINTED" },
+      [letters[3].id]: { status: "CANCELLED" },
+    });
 
     const response = await request.post(`${baseUrl}/${SUPPLIER_LETTERS}`, {
       headers,