Fix some values and increase cert expiry from 14 to 30

Author: francisco-videira-nhs

infrastructure/terraform/components/api/module_authorizer_lambda.tf

@@ -36,7 +36,7 @@ module "authorizer_lambda" {
 
   lambda_env_vars = {
     CLOUDWATCH_NAMESPACE                     = "/aws/api-gateway/supplier/alarms",
-    CLIENT_CERTIFICATE_EXPIRATION_ALERT_DAYS = 14,
+    CLIENT_CERTIFICATE_EXPIRATION_ALERT_DAYS = 30,
     APIM_SUPPLIER_ID_HEADER                  = "NHSD-Supplier-ID",
     SUPPLIERS_TABLE_NAME                     = aws_dynamodb_table.suppliers.name
   }

infrastructure/terraform/modules/alarms/alarms-lambda/main.tf

@@ -1,6 +1,6 @@
 resource "aws_cloudwatch_metric_alarm" "errors" {
   alarm_name        = "${var.alarm_prefix}-lambda-${var.function_name}-errors"
-  alarm_description = "RELIABILITY: Lambda errors"
+  alarm_description = "ERROR: Lambda errors"
 
   namespace   = "AWS/Lambda"
   metric_name = "Errors"
@@ -60,7 +60,7 @@ resource "aws_cloudwatch_log_metric_filter" "error_logs" {
 resource "aws_cloudwatch_metric_alarm" "error_logs" {
   count               = var.enable_error_log_metric ? 1 : 0
   alarm_name          = "${var.alarm_prefix}-lambda-${var.function_name}-error-logs"
-  alarm_description   = "RELIABILITY: Lambda error logs detected"
+  alarm_description   = "ERROR: Lambda error logs detected"
 
   namespace   = var.error_log_metric_namespace
   metric_name = "${var.error_log_metric_name_prefix}${var.function_name}"

infrastructure/terraform/modules/alarms/alarms-lambda/variables.tf

@@ -53,7 +53,7 @@ variable "error_log_metric_name_prefix" {
 
 variable "error_log_metric_filter_pattern" {
   type    = string
-  default = "?ERROR ?Error ?Exception"
+  default = "{ ($.level = \"50\" || $.level = \"error\") && $.environment = * }"
 }
 
 variable "error_log_threshold" {

infrastructure/terraform/modules/alarms/alarms-sqs/variables.tf

@@ -23,7 +23,7 @@ variable "age_period_seconds" {
 
 variable "age_anomaly_sensitivity" {
   type    = number
-  default = 2
+  default = 3
 }
 
 variable "age_anomaly_evaluation_periods" {

lambdas/authorizer/src/__tests__/index.test.ts

@@ -13,7 +13,7 @@ const mockedDeps: jest.Mocked<Deps> = {
   logger: { info: jest.fn(), error: jest.fn() } as unknown as pino.Logger,
   env: {
     CLOUDWATCH_NAMESPACE: "cloudwatch-namespace",
-    CLIENT_CERTIFICATE_EXPIRATION_ALERT_DAYS: 14,
+    CLIENT_CERTIFICATE_EXPIRATION_ALERT_DAYS: 30,
     APIM_SUPPLIER_ID_HEADER: "NHSD-Supplier-ID",
   } as unknown as EnvVars,
   supplierRepo: {