Fix sqs name

Author: francisco-videira-nhs

infrastructure/terraform/components/api/module_lambda_post_letters_receiver.tf

@@ -36,7 +36,8 @@ module "post_letters_receiver" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = merge(local.common_lambda_env_vars, {
-    QUEUE_URL = module.letter_status_updates_queue.sqs_queue_url
+    QUEUE_URL = module.letter_status_updates_queue.queue_url,
+    MAX_LIMIT = var.max_get_limit
   })
 }
 

lambdas/api-handler/src/config/__tests__/env.test.ts

@@ -21,7 +21,7 @@ describe('lambdaEnv', () => {
     process.env.MI_TTL_HOURS = '2160';
     process.env.DOWNLOAD_URL_TTL_SECONDS = '60';
     process.env.MAX_LIMIT = '2500';
-    process.env.SQS_QUEUE_URL = 'url';
+    process.env.QUEUE_URL = 'url';
 
     const { envVars } = require('../env');
 
@@ -34,7 +34,7 @@ describe('lambdaEnv', () => {
       MI_TTL_HOURS: 2160,
       DOWNLOAD_URL_TTL_SECONDS: 60,
       MAX_LIMIT: 2500,
-      SQS_QUEUE_URL: 'url'
+      QUEUE_URL: 'url'
     });
   });
 

lambdas/api-handler/src/config/env.ts

@@ -9,7 +9,7 @@ const EnvVarsSchema = z.object({
   MI_TTL_HOURS:  z.coerce.number().int(),
   DOWNLOAD_URL_TTL_SECONDS: z.coerce.number().int(),
   MAX_LIMIT: z.coerce.number().int().optional(),
-  SQS_QUEUE_URL: z.coerce.string().optional()
+  QUEUE_URL: z.coerce.string().optional()
 });
 
 export type EnvVars = z.infer<typeof EnvVarsSchema>;

lambdas/api-handler/src/handlers/__tests__/letter-status-update.test.ts

@@ -52,7 +52,7 @@ describe('createLetterStatusUpdateHandler', () => {
         LETTER_TTL_HOURS: 12960,
         DOWNLOAD_URL_TTL_SECONDS: 60,
         MAX_LIMIT: 2500,
-        SQS_QUEUE_URL: 'SQS_URL'
+        QUEUE_URL: 'SQS_URL'
       } as unknown as EnvVars
     } as Deps;
 
@@ -82,7 +82,7 @@ describe('createLetterStatusUpdateHandler', () => {
         LETTER_TTL_HOURS: 12960,
         DOWNLOAD_URL_TTL_SECONDS: 60,
         MAX_LIMIT: 2500,
-        SQS_QUEUE_URL: 'SQS_URL'
+        QUEUE_URL: 'SQS_URL'
       } as unknown as EnvVars
     } as Deps;
 

lambdas/api-handler/src/handlers/__tests__/post-letters-receiver.test.ts

@@ -73,7 +73,7 @@ describe('postLetters API Handler', () => {
       LETTER_TTL_HOURS: 12960,
       DOWNLOAD_URL_TTL_SECONDS: 60,
       MAX_LIMIT: 2500,
-      SQS_QUEUE_URL: 'SQS_URL'
+      QUEUE_URL: 'SQS_URL'
     } as unknown as EnvVars
   } as Deps;
 

lambdas/api-handler/src/handlers/post-letters-receiver.ts

@@ -18,7 +18,7 @@ export function createPostLettersReceiverHandler(deps: Deps): APIGatewayProxyHan
     }
 
     const maxUpdateItems = requireEnvVar(deps.env, "MAX_LIMIT");
-    requireEnvVar(deps.env, "SQS_QUEUE_URL");
+    requireEnvVar(deps.env, "QUEUE_URL");
 
     try {
       const body = assertNotEmpty(event.body, new ValidationError(ApiErrorDetail.InvalidRequestMissingBody));

lambdas/api-handler/src/services/__tests__/letter-operations.test.ts

@@ -260,15 +260,15 @@ describe('enqueueLetterUpdateRequests function', () => {
     const sqsClient = { send: jest.fn() } as unknown as SQSClient;
     const logger = { error: jest.fn() } as unknown as pino.Logger;
     const env = {
-      SQS_QUEUE_URL: 'sqsUrl'
+      QUEUE_URL: 'sqsUrl'
     };
     const deps: Deps = { sqsClient, logger, env } as Deps;
 
     const result = await enqueueLetterUpdateRequests(updateLettersRequest, 'supplier1', 'correlationId1', deps);
 
     expect(deps.sqsClient.send).toHaveBeenNthCalledWith(1, expect.objectContaining({
       input: {
-        QueueUrl: deps.env.SQS_QUEUE_URL,
+        QueueUrl: deps.env.QUEUE_URL,
         MessageAttributes: {
           CorrelationId: {
             DataType: 'String',
@@ -287,7 +287,7 @@ describe('enqueueLetterUpdateRequests function', () => {
 
     expect(deps.sqsClient.send).toHaveBeenNthCalledWith(2, expect.objectContaining({
       input: {
-        QueueUrl: deps.env.SQS_QUEUE_URL,
+        QueueUrl: deps.env.QUEUE_URL,
         MessageAttributes: {
           CorrelationId: {
             DataType: 'String',
@@ -323,7 +323,7 @@ describe('enqueueLetterUpdateRequests function', () => {
     const sqsClient = { send: jest.fn().mockRejectedValue(mockError) } as unknown as SQSClient;
     const logger = { error: jest.fn() } as unknown as pino.Logger;
     const env = {
-      SQS_QUEUE_URL: 'sqsUrl'
+      QUEUE_URL: 'sqsUrl'
     };
     const deps: Deps = { sqsClient, logger, env } as Deps;
 

lambdas/api-handler/src/services/letter-operations.ts

@@ -84,7 +84,7 @@ export async function enqueueLetterUpdateRequests(postLettersRequest: PostLetter
   const tasks = postLettersRequest.data.map(async (request) => {
     try {
       const command = new SendMessageCommand({
-        QueueUrl: deps.env.SQS_QUEUE_URL,
+        QueueUrl: deps.env.QUEUE_URL,
         MessageAttributes: {
           CorrelationId: { DataType: 'String', StringValue: correlationId },
         },