terraform fixes

Author: stevebux

infrastructure/terraform/components/api/module_sqs_amendments_queue.tf

@@ -41,7 +41,7 @@ data "aws_iam_policy_document" "letter_updates_queue_policy" {
     condition {
       test     = "ArnEquals"
       variable = "aws:SourceArn"
-      values   = [module.eventsub.sns_topic.arn]
+      values   = [module.eventsub.sns_topic_event_bus.arn]
     }
   }
 
@@ -68,7 +68,7 @@ data "aws_iam_policy_document" "letter_updates_queue_policy" {
     condition {
       test     = "ArnEquals"
       variable = "aws:SourceArn"
-      values   = [module.eventsub.sns_topic.arn]
+      values   = [module.eventsub.sns_topic_event_bus.arn]
     }
   }
 }

infrastructure/terraform/components/api/sns_topic_subscription_allocation_lambda.tf

@@ -1,5 +1,5 @@
 resource "aws_sns_topic_subscription" "allocation_lambda" {
-  topic_arn = module.eventsub.aws_sns_topic.sns_topic_event_bus.arn
+  topic_arn = module.eventsub.sns_topic_event_bus.arn
   protocol  = "lambda"
   endpoint  = module.allocation_lambda.function_arn
 }
@@ -9,5 +9,5 @@ resource "aws_lambda_permission" "allocation_lambda_sns" {
   action        = "lambda:InvokeFunction"
   function_name = module.allocation_lambda.function_name
   principal     = "sns.amazonaws.com"
-  source_arn    = module.eventsub.aws_sns_topic.sns_topic_event_bus.arn
+  source_arn    = module.eventsub.sns_topic_event_bus.arn
 }

infrastructure/terraform/modules/eventsub/README.md

@@ -40,7 +40,8 @@
 | Name | Description |
 |------|-------------|
 | <a name="output_s3_bucket_event_cache"></a> [s3\_bucket\_event\_cache](#output\_s3\_bucket\_event\_cache) | S3 Bucket ARN and Name for event cache |
-| <a name="output_sns_topic"></a> [sns\_topic](#output\_sns\_topic) | SNS Topic ARN and Name |
+| <a name="output_sns_topic_event_bus"></a> [sns\_topic\_event\_bus](#output\_sns\_topic\_event\_bus) | SNS Topic ARN and Name |
+| <a name="output_sns_topic_supplier"></a> [sns\_topic\_supplier](#output\_sns\_topic\_supplier) | SNS Topic ARN and Name |
 <!-- vale on -->
 <!-- markdownlint-enable -->
 <!-- END_TF_DOCS -->

infrastructure/terraform/modules/eventsub/outputs.tf

@@ -1,11 +1,19 @@
-output "sns_topic" {
+output "sns_topic_event_bus" {
   description = "SNS Topic ARN and Name"
   value = {
     arn  = aws_sns_topic.sns_topic_event_bus.arn
     name = aws_sns_topic.sns_topic_event_bus.name
   }
 }
 
+output "sns_topic_supplier" {
+  description = "SNS Topic ARN and Name"
+  value = {
+    arn  = aws_sns_topic.sns_topic_supplier.arn
+    name = aws_sns_topic.sns_topic_supplier.name
+  }
+}
+
 output "s3_bucket_event_cache" {
   description = "S3 Bucket ARN and Name for event cache"
   value = var.enable_event_cache ? {