fixes

Author: Namitha-Prabhu

tests/component-tests/letterQueue-tests/queue-operations.spec.ts

@@ -6,7 +6,11 @@ import {
 } from "tests/helpers/event-fixtures";
 import { logger } from "tests/helpers/pino-logger";
 import { sendSnsBatchEvent, sendSnsEvent } from "tests/helpers/send-sns-event";
-import { supplierIdFromSupplierAllocatorLog } from "tests/helpers/aws-cloudwatch-helper";
+import {
+  pollUpdateLetterQueueDuplicateLog,
+  pollUpsertLetterLogForError,
+  supplierIdFromSupplierAllocatorLog,
+} from "tests/helpers/aws-cloudwatch-helper";
 import getRestApiGatewayBaseUrl from "tests/helpers/aws-gateway-helper";
 import { SUPPLIER_LETTERS } from "tests/constants/api-constants";
 import { supplierDataSetup } from "tests/helpers/suppliers-setup-helper";
@@ -85,18 +89,23 @@ test.describe("Letter Queue Tests", () => {
         message: event,
       })),
     );
-    expect(response.Successful).toBeTruthy();
+    expect(response.Successful).toHaveLength(eventBatch.length);
 
     const supplierId = await supplierIdFromSupplierAllocatorLog(letterId);
 
     logger.info(
-      `Verifying if only one entry is inserted in the letter queue table for the batch of events with same letterId ${letterId}`,
+      `Verifying duplicate queue inserts are ignored for the batch of events with same letterId ${letterId}`,
     );
     const [letterExists, itemCount] = await checkLetterQueueTable(
       supplierId,
       letterId,
     );
     expect(letterExists).toBe(true);
     expect(itemCount).toBe(1);
+
+    await pollUpsertLetterLogForError(
+      `Letter with id ${letterId} already exists for supplier ${supplierId}"`,
+      letterId,
+    );
   });
 });

tests/helpers/generate-fetch-test-data.ts

@@ -148,7 +148,8 @@ export async function checkSupplierExists(
 
     const { Items } = await docClient.send(new QueryCommand(params));
     return Items !== undefined && Items.length > 0;
-  } catch {
+  } catch (error) {
+    logger.error({ supplierId, error }, "Supplier existence check failed");
     return false;
   }
 }
@@ -190,7 +191,7 @@ export async function checkLetterQueueTable(
         );
         return [true, Items.length];
       }
-      if (deleteAfterCheck && Items?.length === 0) {
+      if (deleteAfterCheck && Items !== undefined && Items.length === 0) {
         logger.info(
           `Queried letter queue table to verify deletion for letterId ${letterId} and found no items, confirming deletion`,
         );

tests/helpers/poll-for-letters-helper.ts

@@ -58,7 +58,7 @@ export async function pollForLettersInDb(
   return pollForLetterStatus(request, supplierId, domainId, baseUrl);
 }
 
-export async function pollForLettersInLetterQueue(
+export async function getLetterStatusFromApi(
   request: APIRequestContext,
   supplierId: string,
   domainId: string,

tests/helpers/send-sns-event.ts

@@ -32,6 +32,11 @@ export async function sendSnsEvent(
 export async function sendSnsBatchEvent(
   messages: SnsBatchEventEntry[],
 ): Promise<PublishBatchCommandOutput> {
+  if (messages.length > 10) {
+    throw new Error(
+      "SNS batch publish supports a maximum of 10 messages per batch",
+    );
+  }
   const publishBatchRequestEntries: PublishBatchRequestEntry[] = messages.map(
     ({ id, message, messageAttributes }, index) => ({
       Id: id ?? `message-${index + 1}`,