Terraform fixes

Author: stevebux

infrastructure/terraform/components/api/module_lambda_allocation.tf

@@ -40,6 +40,7 @@ module "allocation_lambda" {
   }
 }
 
+
 data "aws_iam_policy_document" "allocation_lambda" {
   statement {
     sid    = "KMSPermissions"
@@ -54,4 +55,18 @@ data "aws_iam_policy_document" "allocation_lambda" {
       module.kms.key_arn,
     ]
   }
+
+  statement {
+    sid    = "AllowQueueAccess"
+    effect = "Allow"
+
+    actions = [
+      "sqs:SendMessage",
+      "sqs:GetQueueAttributes",
+    ]
+
+    resources = [
+      module.amendments_queue.sqs_queue_arn
+    ]
+  }
 }

infrastructure/terraform/components/api/module_sqs_amendments_queue.tf

@@ -18,31 +18,3 @@ module "amendments_queue" {
   create_dlq          = true
   sqs_policy_overload = data.aws_iam_policy_document.amendments_queue_policy.json
 }
-
-data "aws_iam_policy_document" "amendments_queue_policy" {
-  version = "2012-10-17"
-  statement {
-    sid    = "AllowSNSToSendMessage"
-    effect = "Allow"
-
-    principals {
-      type        = "Service"
-      identifiers = ["sns.amazonaws.com"]
-    }
-
-    actions = [
-      "sqs:SendMessage"
-    ]
-
-    resources = [
-      "arn:aws:sqs:${var.region}:${var.aws_account_id}:${local.csi}-amendments-queue.fifo"
-    ]
-
-    condition {
-      test     = "ArnEquals"
-      variable = "aws:SourceArn"
-      values   = [module.eventsub.sns_topic_event_bus.arn, module.eventsub.sns_topic_supplier.arn]
-
-    }
-  }
-}