Make sqs msg age alarms same period; some tf lint

Author: francisco-videira-nhs

infrastructure/terraform/components/api/alarms.tf

@@ -16,19 +16,19 @@ locals {
 
   sqs_queue_names = {
     letter_updates = {
-      name              = module.sqs_letter_updates.sqs_queue_name
+      name               = module.sqs_letter_updates.sqs_queue_name
       age_period_seconds = 900
     }
     letter_status_updates = {
-      name              = module.letter_status_updates_queue.sqs_queue_name
-      age_period_seconds = 300
+      name               = module.letter_status_updates_queue.sqs_queue_name
+      age_period_seconds = 900
     }
   }
 }
 
 module "lambda_alarms" {
-  for_each   = local.lambda_alarm_targets
-  source     = "../../modules/alarms/alarms-lambda"
+  for_each = local.lambda_alarm_targets
+  source   = "../../modules/alarms/alarms-lambda"
 
   alarm_prefix   = local.csi
   function_name  = each.value
@@ -58,14 +58,14 @@ module "ddb_alarms_suppliers" {
 }
 
 module "sqs_alarms" {
-  for_each   = local.sqs_queue_names
-  source     = "../../modules/alarms/alarms-sqs"
+  for_each = local.sqs_queue_names
+  source   = "../../modules/alarms/alarms-sqs"
 
-  alarm_prefix   = local.csi
-  queue_name     = each.value.name
-  dlq_queue_name = replace(each.value.name, "-queue", "-dlq")
+  alarm_prefix       = local.csi
+  queue_name         = each.value.name
+  dlq_queue_name     = replace(each.value.name, "-queue", "-dlq")
   age_period_seconds = each.value.age_period_seconds
-  tags           = local.default_tags
+  tags               = local.default_tags
 }
 
 module "apigw_alarms" {

infrastructure/terraform/modules/alarms/alarms-lambda/main.tf

@@ -58,9 +58,9 @@ resource "aws_cloudwatch_log_metric_filter" "error_logs" {
 }
 
 resource "aws_cloudwatch_metric_alarm" "error_logs" {
-  count               = var.enable_error_log_metric ? 1 : 0
-  alarm_name          = "${var.alarm_prefix}-lambda-${var.function_name}-error-logs"
-  alarm_description   = "ERROR: Lambda error logs detected"
+  count             = var.enable_error_log_metric ? 1 : 0
+  alarm_name        = "${var.alarm_prefix}-lambda-${var.function_name}-error-logs"
+  alarm_description = "ERROR: Lambda error logs detected"
 
   namespace   = var.error_log_metric_namespace
   metric_name = "${var.error_log_metric_name_prefix}${var.function_name}"

infrastructure/terraform/modules/alarms/alarms-sqs/main.tf

@@ -38,9 +38,9 @@ resource "aws_cloudwatch_metric_alarm" "age_anomaly" {
 }
 
 resource "aws_cloudwatch_metric_alarm" "dlq_depth" {
-  count               = var.dlq_queue_name == null ? 0 : 1
-  alarm_name          = "${var.alarm_prefix}-sqs-${var.dlq_queue_name}-dlq-depth"
-  alarm_description   = "RELIABILITY: SQS DLQ has messages"
+  count             = var.dlq_queue_name == null ? 0 : 1
+  alarm_name        = "${var.alarm_prefix}-sqs-${var.dlq_queue_name}-dlq-depth"
+  alarm_description = "RELIABILITY: SQS DLQ has messages"
 
   namespace   = "AWS/SQS"
   metric_name = "ApproximateNumberOfMessagesVisible"