fix linting errors

Author: Vlasis-Perdikidis

tests/config/global-setup.ts

@@ -1,3 +1,4 @@
+import { logger } from "tests/helpers/pino-logger";
 import {
   checkSupplierExists,
   createSupplierEntry,
@@ -6,9 +7,9 @@ import {
 import { SUPPLIERID } from "../constants/api-constants";
 
 async function globalSetup() {
-  console.log("");
-  console.log("*** BEGINNING GLOBAL SETUP ***");
-  console.log("");
+  logger.info("");
+  logger.info("*** BEGINNING GLOBAL SETUP ***");
+  logger.info("");
 
   // create test data
 
@@ -17,19 +18,19 @@ async function globalSetup() {
   // check supplier exists
   const supplier = await checkSupplierExists(SUPPLIERID);
   if (supplier) {
-    console.log(`Supplier with ID ${SUPPLIERID} already exists.`);
-    console.log("");
-    console.log("*** GLOBAL SETUP COMPLETE ***");
-    console.log("");
+    logger.info(`Supplier with ID ${SUPPLIERID} already exists.`);
+    logger.info("");
+    logger.info("*** GLOBAL SETUP COMPLETE ***");
+    logger.info("");
     return;
   }
 
-  console.log(`Creating supplier entry with ID: ${SUPPLIERID}`);
+  logger.info(`Creating supplier entry with ID: ${SUPPLIERID}`);
   await createSupplierEntry(SUPPLIERID);
 
-  console.log("");
-  console.log("*** GLOBAL SETUP COMPLETE ***");
-  console.log("");
+  logger.info("");
+  logger.info("*** GLOBAL SETUP COMPLETE ***");
+  logger.info("");
 }
 
 export default globalSetup;

tests/helpers/aws-lambda-helper.ts

@@ -24,7 +24,7 @@ export async function updateLambdaEnv(
   functionArn: string,
   variables: Record<string, string>,
 ) {
-  return await lambdaClient.send(
+  return lambdaClient.send(
     new UpdateFunctionConfigurationCommand({
       FunctionName: functionArn,
       Environment: { Variables: variables },

tests/performance/testCases/send-prepared-letter-request.spec.ts

@@ -8,7 +8,6 @@ import { retrieveKinesisRecordsAtTimestamp } from "tests/helpers/aws-kinesis-hel
 import { logger } from "tests/helpers/pino-logger";
 import { envName } from "tests/constants/api-constants";
 import PREPARED_LETTER from "../../resources/prepared-letter.json";
-import { assert } from "console";
 
 test.describe("Performance test checking how long it takes letter requests from the EventSub SNS to reach the Letters Database ", () => {
   test("send 2500 letter requests", async () => {