fix tests and update script comments

Author: masl2

scripts/utilities/letter-test-data/src/__test__/helpers/create_letter_helpers.test.ts

@@ -44,7 +44,7 @@ describe("Create letter helpers", () => {
     expect(mockedUploadFile).toHaveBeenCalledWith(
       "bucketName",
       "supplierId",
-      "../test-letters/test-letter-standard.pdf",
+      "test-letter-standard.pdf",
       "targetFilename",
     );
     expect(mockPutLetter).toHaveBeenCalledWith({
@@ -104,6 +104,9 @@ describe("Create letter helpers", () => {
       supplierId: "supplierId",
       updatedAt: "2020-02-01T00:00:00.000Z",
       url: "s3://bucketName/supplierId/targetFilename",
+      billingRef: "specificationId",
+      source: "/data-plane/letter-rendering/letter-test-data",
+      subject: "supplier-api/letter-test-data/letterId",
     });
   });
 

scripts/utilities/letter-test-data/src/create-batch-letters.sh

@@ -117,7 +117,7 @@ PROJECT_DIR="$(dirname "$SCRIPT_DIR")"
 # Change to the project directory
 cd "$PROJECT_DIR"
 
-# Define the three batches with different specification and group IDs
+# Define the batches with different specification and group IDs
 BATCHES=(
     "integration-specification-english:group-english:test-letter-standard:${COUNT}"
     "integration-specification-braille:group-accessible:test-letter-standard:${COUNT}"
@@ -135,7 +135,7 @@ echo ""
 
 # Create each batch
 for batch in "${BATCHES[@]}"; do
-    # Parse specification-id and group-id from the batch definition
+    # Parse specification-id, group-id and batch volume from the batch definition
     IFS=':' read -r SPEC_ID GROUP_ID TEST_LETTER BATCH_COUNT <<< "$batch"
 
     echo "[$BATCH_COUNTER/$TOTAL_BATCHES] Creating batch with specification-id: $SPEC_ID, group-id: $GROUP_ID-$SUPPLIER_ID"