Allow for data coming through bit by bit

Author: stevebux

tests/e2e-tests/api/data/test_get_letter_data.py

@@ -4,6 +4,7 @@
 from lib.fixtures import *  # NOSONAR
 from lib.constants import LETTERS_ENDPOINT
 from lib.generators import Generators
+from lib.letters import get_pending_letter_ids
 from lib.errorhandler import ErrorHandler
 
 @pytest.mark.test
@@ -12,10 +13,9 @@
 @pytest.mark.prodtest
 def test_200_get_letter_status(url, authentication_secret):
     headers = Generators.generate_valid_headers(authentication_secret)
-    get_letter_id = requests.get(f"{url}/{LETTERS_ENDPOINT}/", headers=headers)
+    ids = get_pending_letter_ids(url, headers, LETTERS_ENDPOINT, limit=1)
 
-    letter_id = get_letter_id.json().get("data")[0].get("id")
-    get_letter_data = requests.get(f"{url}/{LETTERS_ENDPOINT}/{letter_id}/data", headers=headers)
+    get_letter_data = requests.get(f"{url}/{LETTERS_ENDPOINT}/{ids[0]}/data", headers=headers)
 
     ErrorHandler.handle_retry(get_letter_data)
     assert get_letter_data.status_code == 200, f"Response: {get_letter_data.status_code}: {get_letter_data.text}"

tests/e2e-tests/api/letters/conftest.py

@@ -10,10 +10,5 @@ def seed_letter_test_data():
     createTestData() used by the component tests
     (tests/config/global-setup.ts). Session-scoped so it runs once per
     test session. autouse=True means no test needs to reference it explicitly.
-
-    Note: we do not poll the API after seeding here because GET /letters
-    applies a visibility timeout to every letter it returns, which would
-    consume letters before the tests can use them. Retry logic for empty
-    responses is handled within each test instead.
     """
     create_test_data(count=10)

tests/e2e-tests/lib/letters.py

@@ -65,12 +65,13 @@ def get_pending_letter_ids(
     for _ in range(retries):
         create_test_data(limit)
         deadline = time.monotonic() + timeout_s
+        data = []
         while time.monotonic() < deadline:
             response = requests.get(
                 f"{url}/{letters_endpoint}?limit={limit}", headers=headers
             )
             response.raise_for_status()
-            data = response.json().get("data", [])
+            data.extend(response.json().get("data", []))
             if len(data) >= limit:
                 return [item.get("id") for item in data]
             time.sleep(interval_s)