log letterEvent and operation

Author: Vlasis-Perdikidis

README.md

@@ -138,5 +138,3 @@ Deployments can be made of any [release](https://github.com/NHSDigital/nhs-notif
 Unless stated otherwise, the codebase is released under the MIT License. This covers both the codebase and any sample code in the documentation.
 
 Any HTML or Markdown documentation is [© Crown Copyright](https://www.nationalarchives.gov.uk/information-management/re-using-public-sector-information/uk-government-licensing-framework/crown-copyright/) and available under the terms of the [Open Government Licence v3.0](https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/).
-
-to open a PR

infrastructure/terraform/components/api/module_lambda_upsert_letter.tf

@@ -85,16 +85,4 @@ data "aws_iam_policy_document" "upsert_letter_lambda" {
       module.sqs_letter_updates.sqs_queue_arn
     ]
   }
-
-  statement {
-    sid = "AllowCloudWatchMetrics"
-    effect = "Allow"
-
-    actions = [
-      "cloudwatch:PutMetricData"
-    ]
-
-    resources = ["*"]
-  }
-
 }

lambdas/upsert-letter/package.json

@@ -1,6 +1,5 @@
 {
   "dependencies": {
-    "@aws-sdk/client-cloudwatch": "^3.972.0",
     "@aws-sdk/client-dynamodb": "^3.858.0",
     "@aws-sdk/lib-dynamodb": "^3.858.0",
     "@internal/datastore": "*",

lambdas/upsert-letter/src/handler/upsert-handler.ts

@@ -162,7 +162,9 @@ export default function createUpsertLetterHandler(deps: Deps): SQSHandler {
       );
       console.log("The SQSEvent:", event);
       const batchItemFailures: SQSBatchItemFailure[] = [];
-      metrics.setNamespace("vlasis_upsertLetter");
+      metrics.setNamespace(
+        process.env.AWS_LAMBDA_FUNCTION_NAME || "upsertletter",
+      );
 
       const tasks = event.Records.map(async (record) => {
         try {
@@ -177,8 +179,9 @@ export default function createUpsertLetterHandler(deps: Deps): SQSHandler {
           const type = getType(letterEvent);
 
           const operation = getOperationFromType(type);
+          console.log("letterEvent: ", letterEvent);
+          console.log("operation: ", operation);
           metrics.putDimensions({
-            FunctionName: "upsertLambda",
             // eslint-disable-next-line sonarjs/pseudo-random
             OddOrEven: `${Math.floor(Math.random() * 10) % 2}`,
           });
@@ -193,7 +196,6 @@ export default function createUpsertLetterHandler(deps: Deps): SQSHandler {
             `Error processing upsert of record ${record.messageId}`,
           );
           metrics.putDimensions({
-            FunctionName: "upsertLambda",
             // eslint-disable-next-line sonarjs/pseudo-random
             OddOrEven: `${Math.floor(Math.random() * 10) % 2}`,
           });