Skip to content

Commit c5bef3d

Browse files
CCM-15391 - add lodash to sandbox dependencies (#464)
* CCM-15391 - add lodash to sandbox dependencies * temp remove acceptance tests
1 parent 3820d92 commit c5bef3d

File tree

3 files changed

+7
-40
lines changed

3 files changed

+7
-40
lines changed

.github/workflows/stage-4-acceptance.yaml

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -44,44 +44,6 @@ permissions:
4444
contents: read
4545

4646
jobs:
47-
run-acceptance-tests:
48-
name: Run Acceptance Tests
49-
runs-on: ubuntu-latest
50-
steps:
51-
- uses: actions/checkout@v5.0.0
52-
53-
- name: "Use Node.js"
54-
uses: actions/setup-node@v6
55-
with:
56-
node-version: "${{ inputs.nodejs_version }}"
57-
registry-url: "https://npm.pkg.github.com"
58-
scope: "@nhsdigital"
59-
60-
- name: "Set environment"
61-
shell: bash
62-
run: |
63-
if [ "${{ inputs.pr_number }}" != "" ]; then
64-
echo "ENVIRONMENT=pr${{ inputs.pr_number }}" >> $GITHUB_ENV
65-
else
66-
echo "ENVIRONMENT=main" >> $GITHUB_ENV
67-
fi
68-
69-
- name: Trigger Acceptance Tests
70-
shell: bash
71-
env:
72-
APP_PEM_FILE: ${{ secrets.APP_PEM_FILE }}
73-
APP_CLIENT_ID: ${{ secrets.APP_CLIENT_ID }}
74-
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
75-
run: |
76-
.github/scripts/dispatch_internal_repo_workflow.sh \
77-
--targetWorkflow "dispatch-contextual-tests-dynamic-env.yaml" \
78-
--infraRepoName "nhs-notify-supplier-api" \
79-
--releaseVersion "${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" \
80-
--overrideProjectName "nhs" \
81-
--targetEnvironment "$ENVIRONMENT" \
82-
--targetAccountGroup "nhs-notify-supplier-api-dev" \
83-
--targetComponent "api"
84-
8547
run-e2e-tests:
8648
name: Run End-to-End Tests
8749
runs-on: ubuntu-latest

sandbox/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ COPY . /sandbox
66

77
WORKDIR /sandbox
88

9-
109
RUN npm install
1110

1211
EXPOSE 9000

sandbox/package.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,20 @@
77
"express": "^4.16.4",
88
"express-openapi-validator": "^4.13.8",
99
"js-yaml": "^3.3.0",
10+
"lodash": "^4.17.21",
1011
"ono": "^5.0.1",
1112
"openapi-sampler": "^1.0.0-beta.15",
1213
"swagger-ui-express": "^4.0.2",
1314
"winston": "^3.2.1"
1415
},
1516
"description": "API for communication suppliers to integrate with NHS Notify. This specification represents the in-development 'next' version of the API schema and should be treated as unstable. ",
1617
"devDependencies": {
17-
"eslint-config-airbnb-base": "^15.0.0"
18+
"chai": "^4.2.0",
19+
"chai-as-promised": "^7.1.1",
20+
"eslint": "^5.16.0",
21+
"eslint-config-airbnb-base": "^14.0.0",
22+
"eslint-plugin-import": "^2.17.2",
23+
"mocha": "^11.7.1"
1824
},
1925
"eslintConfig": {
2026
"env": {

0 commit comments

Comments
 (0)