Switch letter_status_update lambda to use eventsub SNS topic

Author: stevebux

.vscode/settings.json

@@ -10,5 +10,6 @@
     "**/Thumbs.db": true,
     ".github": false,
     ".vscode": false
-  }
+  },
+  "typescript.tsdk": "node_modules/typescript/lib"
 }

infrastructure/terraform/components/api/module_lambda_letter_status_update.tf

@@ -34,7 +34,10 @@ module "letter_status_update" {
   log_destination_arn       = local.destination_arn
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
-  lambda_env_vars = merge(local.common_lambda_env_vars, {})
+  lambda_env_vars = merge(local.common_lambda_env_vars, {
+    SNS_TOPIC_ARN = "${module.eventsub.sns_topic.arn}",
+    EVENT_SOURCE = "/data-plane/supplier-api/${var.group}/${var.environment}/letters"
+  })
 }
 
 data "aws_iam_policy_document" "letter_status_update" {
@@ -59,7 +62,6 @@ data "aws_iam_policy_document" "letter_status_update" {
     actions = [
       "dynamodb:GetItem",
       "dynamodb:Query",
-      "dynamodb:UpdateItem",
     ]
 
     resources = [
@@ -68,18 +70,15 @@ data "aws_iam_policy_document" "letter_status_update" {
   }
 
   statement {
-    sid    = "AllowQueueAccess"
+    sid    = "AllowSNSPublish"
     effect = "Allow"
 
     actions = [
-      "sqs:ReceiveMessage",
-      "sqs:DeleteMessage",
-      "sqs:GetQueueAttributes",
-      "sqs:ChangeMessageVisibility"
+      "sns:Publish"
     ]
 
     resources = [
-      module.letter_status_updates_queue.sqs_queue_arn
+      module.eventsub.sns_topic.arn
     ]
   }
 }

internal/events/jest.config.ts

@@ -24,7 +24,7 @@ export const baseJestConfig: Config = {
     },
   },
 
-  coveragePathIgnorePatterns: ["/__tests__/"],
+  coveragePathIgnorePatterns: ["/src/index.ts$", "/__tests__/"],
   transform: { "^.+\\.ts$": "ts-jest" },
   testPathIgnorePatterns: [".build"],
   testMatch: ["**/?(*.)+(spec|test).[jt]s?(x)"],

internal/events/package.json

@@ -1,6 +1,7 @@
 {
   "dependencies": {
     "@asyncapi/bundler": "^0.6.4",
+    "@internal/datastore": "*",
     "zod": "^4.1.11"
   },
   "description": "Schemas for NHS Notify Supplier API events",

…/mappers/__tests__/letter-mapper.test.ts …c/events/__tests__/letter-mapper.test.tslambdas/letter-updates-transformer/src/mappers/__tests__/letter-mapper.test.ts renamed to internal/events/src/events/__tests__/letter-mapper.test.ts lambdas/letter-updates-transformer/src/mappers/__tests__/letter-mapper.test.ts renamed to internal/events/src/events/__tests__/letter-mapper.test.ts

@@ -1,6 +1,6 @@
 import { $LetterEvent } from "@nhsdigital/nhs-notify-event-schemas-supplier-api/src";
-import { Letter } from "@internal/datastore";
-import mapLetterToCloudEvent from "../letter-mapper";
+import { Letter } from "internal/datastore/src/types";
+import { mapLetterToCloudEvent } from "../letter-mapper";
 
 describe("letter-mapper", () => {
   it("maps a letter to a letter event", async () => {

…transformer/src/mappers/letter-mapper.ts …ernal/events/src/events/letter-mapper.tslambdas/letter-updates-transformer/src/mappers/letter-mapper.ts renamed to internal/events/src/events/letter-mapper.ts lambdas/letter-updates-transformer/src/mappers/letter-mapper.ts renamed to internal/events/src/events/letter-mapper.ts

@@ -1,10 +1,11 @@
-import { LetterEvent } from "@nhsdigital/nhs-notify-event-schemas-supplier-api/src";
 import { randomBytes, randomUUID } from "node:crypto";
 import eventSchemaPackage from "@nhsdigital/nhs-notify-event-schemas-supplier-api/package.json";
-import { LetterForEventPub } from "../types";
+import { Letter } from "internal/datastore/src/types";
+import { LetterEvent } from "./letter-events";
 
-export default function mapLetterToCloudEvent(
-  letter: LetterForEventPub,
+// eslint-disable-next-line import-x/prefer-default-export
+export function mapLetterToCloudEvent(
+  letter: Letter,
   source: string,
 ): LetterEvent {
   const eventId = randomUUID();

internal/events/src/index.ts

@@ -4,3 +4,4 @@ export { default as DomainBase } from "./domain/domain-base";
 export * from "./events/event-envelope";
 export * from "./events/letter-events";
 export * from "./events/mi-events";
+export * from "./events/letter-mapper";

internal/events/tsconfig.json

@@ -3,8 +3,7 @@
     "declaration": true,
     "isolatedModules": true,
     "module": "commonjs",
-    "outDir": "dist",
-    "resolveJsonModule": true
+    "outDir": "dist"
   },
   "exclude": [
     "node_modules",

lambdas/api-handler/package.json

@@ -2,11 +2,13 @@
   "dependencies": {
     "@aws-sdk/client-dynamodb": "^3.925.0",
     "@aws-sdk/client-s3": "^3.925.0",
+    "@aws-sdk/client-sns": "^3.925.0",
     "@aws-sdk/client-sqs": "^3.925.0",
     "@aws-sdk/lib-dynamodb": "^3.925.0",
     "@aws-sdk/s3-request-presigner": "^3.925.0",
     "@internal/datastore": "*",
     "@internal/helpers": "*",
+    "@nhsdigital/nhs-notify-event-schemas-supplier-api": "*",
     "aws-lambda": "^1.0.7",
     "esbuild": "^0.25.11",
     "pino": "^9.7.0",

lambdas/api-handler/src/config/__tests__/env.test.ts

@@ -25,6 +25,8 @@ describe("lambdaEnv", () => {
     process.env.DOWNLOAD_URL_TTL_SECONDS = "60";
     process.env.MAX_LIMIT = "2500";
     process.env.QUEUE_URL = "url";
+    process.env.EVENT_SOURCE = "supplier-api";
+    process.env.SNS_TOPIC_ARN = "sns-topic.arn";
 
     const { envVars } = require("../env");
 
@@ -38,6 +40,8 @@ describe("lambdaEnv", () => {
       DOWNLOAD_URL_TTL_SECONDS: 60,
       MAX_LIMIT: 2500,
       QUEUE_URL: "url",
+      EVENT_SOURCE: "supplier-api",
+      SNS_TOPIC_ARN: "sns-topic.arn",
     });
   });
 
@@ -61,6 +65,8 @@ describe("lambdaEnv", () => {
     process.env.LETTER_TTL_HOURS = "12960";
     process.env.MI_TTL_HOURS = "2160";
     process.env.DOWNLOAD_URL_TTL_SECONDS = "60";
+    process.env.EVENT_SOURCE = "supplier-api";
+    process.env.SNS_TOPIC_ARN = "sns-topic.arn";
 
     const { envVars } = require("../env");
 
@@ -73,6 +79,8 @@ describe("lambdaEnv", () => {
       MI_TTL_HOURS: 2160,
       DOWNLOAD_URL_TTL_SECONDS: 60,
       MAX_LIMIT: undefined,
+      EVENT_SOURCE: "supplier-api",
+      SNS_TOPIC_ARN: "sns-topic.arn",
     });
   });
 });