Remove FIFO-ness experimentally

Author: stevebux

infrastructure/terraform/components/api/module_sqs_amendments_queue.tf

@@ -8,8 +8,8 @@ module "amendments_queue" {
   region         = var.region
   name           = "${local.csi}-amendments-queue"
 
-  fifo_queue                  = true
-  content_based_deduplication = true
+  #fifo_queue                  = true
+  #content_based_deduplication = true
 
   sqs_kms_key_arn = module.kms.key_arn
 

infrastructure/terraform/components/api/sns_topic_subscription_amendments_queue.tf

@@ -2,5 +2,5 @@ resource "aws_sns_topic_subscription" "amendments_queue" {
   topic_arn            = module.eventsub.sns_topic_supplier.arn
   protocol             = "sqs"
   endpoint             = module.amendments_queue.sqs_queue_arn
-  raw_message_delivery = false
+  #raw_message_delivery = false
 }

infrastructure/terraform/modules/eventsub/sns_topic_supplier.tf

@@ -2,8 +2,8 @@ resource "aws_sns_topic" "sns_topic_supplier" {
   name              = "${local.csi}-supplier-events.fifo"
   kms_master_key_id = var.kms_key_arn
 
-  fifo_topic                  = true
-  content_based_deduplication = true
+  #fifo_topic                  = true
+  #content_based_deduplication = true
 
   application_failure_feedback_role_arn    = var.enable_sns_delivery_logging == true ? aws_iam_role.sns_delivery_logging_role[0].arn : null
   application_success_feedback_role_arn    = var.enable_sns_delivery_logging == true ? aws_iam_role.sns_delivery_logging_role[0].arn : null

lambdas/letter-updates-transformer/src/mappers/__tests__/letter-mapper.test.ts

@@ -20,7 +20,7 @@ describe("letter-mapper", () => {
     $LetterEvent.parse(event);
     expect(event.type).toBe("uk.nhs.notify.supplier-api.letter.PRINTED.v1");
     expect(event.dataschema).toBe(
-      `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.PRINTED.${event.dataschemaversion}.schema.json`
+      `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.PRINTED.${event.dataschemaversion}.schema.json`,
     );
     expect(event.dataschemaversion).toMatch(/1\.\d+\.\d+/);
     expect(event.subject).toBe("letter-origin/supplier-api/letter/id1");