fix typeckeck and lint errors

Author: Vlasis-Perdikidis

lambdas/api-handler/src/mappers/__tests__/letter-mapper.test.ts

@@ -3,104 +3,14 @@ import {
   mapToGetLetterResponse,
   mapToGetLettersResponse,
   mapToPatchLetterResponse,
-  mapToUpdateCommands,
 } from "../letter-mapper";
 import {
   GetLetterResponse,
   GetLettersResponse,
   PatchLetterResponse,
-  PostLettersRequest,
 } from "../../contracts/letters";
 
 describe("letter-mapper", () => {
-  it("maps PostLetterRequest to UpdateLetterCommands", () => {
-    const request: PostLettersRequest = {
-      data: [
-        {
-          id: "id1",
-          type: "Letter",
-          attributes: {
-            status: "REJECTED",
-            reasonCode: "123",
-            reasonText: "Reason text",
-          },
-        },
-        { id: "id2", type: "Letter", attributes: { status: "ACCEPTED" } },
-        { id: "id3", type: "Letter", attributes: { status: "DELIVERED" } },
-      ],
-    };
-    const supplierId = "testSupplierId";
-    const updateLetterCommands = mapToUpdateCommands(request, supplierId);
-    expect(updateLetterCommands).toEqual([
-      {
-        id: "id1",
-        reasonCode: "123",
-        reasonText: "Reason text",
-        supplierId: "testSupplierId",
-        status: "REJECTED",
-      },
-      {
-        id: "id2",
-        supplierId: "testSupplierId",
-        status: "ACCEPTED",
-      },
-      {
-        id: "id3",
-        supplierId: "testSupplierId",
-        status: "DELIVERED",
-      },
-    ]);
-  });
-
-  it("maps PostLetterRequest to UpdateLetterCommands and populates statuses map", () => {
-    const request: PostLettersRequest = {
-      data: [
-        {
-          id: "id1",
-          type: "Letter",
-          attributes: {
-            status: "REJECTED",
-            reasonCode: "123",
-            reasonText: "Reason text",
-          },
-        },
-        { id: "id2", type: "Letter", attributes: { status: "ACCEPTED" } },
-        { id: "id3", type: "Letter", attributes: { status: "DELIVERED" } },
-      ],
-    };
-    const supplierId = "testSupplierId";
-    const statusesMap = new Map<string, number>();
-    const updateLetterCommands = mapToUpdateCommands(
-      request,
-      supplierId,
-      statusesMap,
-    );
-    expect(updateLetterCommands).toEqual([
-      {
-        id: "id1",
-        reasonCode: "123",
-        reasonText: "Reason text",
-        supplierId: "testSupplierId",
-        status: "REJECTED",
-      },
-      {
-        id: "id2",
-        supplierId: "testSupplierId",
-        status: "ACCEPTED",
-      },
-      {
-        id: "id3",
-        supplierId: "testSupplierId",
-        status: "DELIVERED",
-      },
-    ]);
-    expect(Object.fromEntries(statusesMap)).toEqual({
-      REJECTED: 1,
-      ACCEPTED: 1,
-      DELIVERED: 1,
-    });
-  });
-
   it("maps an internal Letter to a PatchLetterResponse", () => {
     const date = new Date().toISOString();
     const letter: Letter = {

lambdas/letter-updates-transformer/src/letter-updates-transformer.ts

@@ -14,7 +14,6 @@ import { MetricsLogger, Unit, metricScope } from "aws-embedded-metrics";
 import mapLetterToCloudEvent from "./mappers/letter-mapper";
 import { Deps } from "./deps";
 import { LetterForEventPub, LetterSchemaForEventPub } from "./types";
-import { string } from "zod";
 
 // SNS PublishBatchCommand supports up to 10 messages per batch
 const BATCH_SIZE = 10;