debug logging

Author: nhsd-david-wass

lambdas/supplier-allocator/src/handler/allocate-handler.ts

@@ -28,6 +28,7 @@ import {
   updateSupplierAllocation,
 } from "../services/supplier-quotas";
 import { Deps } from "../config/deps";
+import { de } from "zod/v4/locales";
 
 type SupplierSpec = {
   supplierId: string;
@@ -137,19 +138,11 @@ async function getSupplierFromConfig(
         suppliersForPack.some((supplier) => supplier.id === alloc.supplier),
       );
 
-      console.log("Supplier allocations for pack", {
-        supplierAllocationsForPack,
-      });
-
       supplierFactors = await calculateSupplierAllocatedFactor(
         supplierAllocationsForPack,
         deps,
       );
 
-      console.log("Supplier factors calculated for allocation", {
-        supplierFactors,
-      });
-
       // Get the supplierid with the lowest factor
       selectedSupplierId = supplierFactors[0].supplierId;
       let lowestFactor = supplierFactors[0].factor;
@@ -241,17 +234,27 @@ function incrementAllocation(
   volumeGroupId: string,
   supplierId: string,
   allocation: number,
+  deps: Deps,
 ) {
   const groupAllocations = map.get(volumeGroupId) ?? {};
   groupAllocations[supplierId] =
     (groupAllocations[supplierId] ?? 0) + allocation;
   map.set(volumeGroupId, groupAllocations);
+  deps.logger.info({
+    description: "Updated allocations for volume group and supplier",
+    volumeGroupId,
+    groupAllocations,
+  });
 }
 
 async function saveAllocations(
   deps: Deps,
   volumeGroupAllocations: VolumeGroupAllocation,
 ) {
+  deps.logger.info({
+    description: "Saving supplier allocations for volume groups",
+    volumeGroupAllocations,
+  });
   for (const [volumeGroupId, allocations] of volumeGroupAllocations) {
     for (const [supplierId, allocation] of Object.entries(allocations)) {
       await updateSupplierAllocation(
@@ -291,6 +294,11 @@ export default function createSupplierAllocatorHandler(deps: Deps): SQSHandler {
           deps,
         );
 
+        deps.logger.info({
+          description: "Resolved supplier details from config",
+          supplierDetails,
+        });
+
         incrementAllocation(
           volumeGroupAllocations,
           supplierDetails?.volumeGroupId ?? "unknown",

lambdas/supplier-allocator/src/services/supplier-config.ts

@@ -199,9 +199,6 @@ function evaluateContraint(
   constraintValue: number,
   operator: string,
 ): boolean {
-  console.log(
-    `Evaluating constraint: actualValue ${actualValue}, constraintValue ${constraintValue}, operator ${operator}`,
-  );
   switch (operator) {
     case "EQUALS": {
       return actualValue === constraintValue;

lambdas/supplier-allocator/src/services/supplier-quotas.ts

@@ -1,6 +1,7 @@
 import { DailyAllocation, OverallAllocation } from "@internal/datastore";
 import { SupplierAllocation } from "@nhsdigital/nhs-notify-event-schemas-supplier-config";
 import { Deps } from "../config/deps";
+import { de } from "zod/v4/locales";
 
 export async function calculateSupplierAllocatedFactor(
   supplierAllocations: SupplierAllocation[],
@@ -45,6 +46,11 @@ export async function updateSupplierAllocation(
   const overallAllocation =
     await deps.supplierQuotasRepo.getOverallAllocation(volumeGroupId);
   if (overallAllocation) {
+    deps.logger.info({
+      description: "Existing overall allocation found for volume group",
+      volumeGroupId,
+      overallAllocation,
+    });
     await deps.supplierQuotasRepo.updateOverallAllocation(
       volumeGroupId,
       supplierId,
@@ -58,6 +64,12 @@ export async function updateSupplierAllocation(
         [supplierId]: newAllocation,
       },
     };
+    deps.logger.info({
+      description:
+        "No overall allocation found for volume group, creating new one",
+      volumeGroupId,
+      newOverallAllocation,
+    });
     await deps.supplierQuotasRepo.putOverallAllocation(newOverallAllocation);
   }
   const dailyAllocationDate = new Date().toISOString().split("T")[0]; // Get current date in YYYY-MM-DD format