fix mi typecheck

Author: RossFaulds171

lambdas/api-handler/src/contracts/mi.ts

@@ -45,6 +45,23 @@ export const GetMIResponseResourceSchema = z
   })
   .strict();
 
+  // export const GetMIResponseResourceSchema = z
+  // .object({
+  //   id: z.string(),
+  //   type: z.literal("ManagementInformation"),
+  //   attributes: z
+  //     .object({
+  //       lineItem: z.string(),
+  //       timestamp: z.string(),
+  //       quantity: z.number(),
+  //       specificationId: z.string().optional(),
+  //       groupId: z.string().optional(),
+  //       stockRemaining: z.number().optional(),
+  //     })
+  //     .strict(),
+  // })
+  // .strict();
+
 export const GetMIResponseSchema = makeDocumentSchema(
   GetMIResponseResourceSchema,
 );

lambdas/api-handler/src/mappers/mi-mapper.ts

@@ -1,7 +1,7 @@
 import { MIBase } from "@internal/datastore/src";
 import {
   GetMIResponse,
-  GetMIResponseResourceSchema,
+  GetMIResponseSchema,
   IncomingMI,
   PostMIRequest,
   PostMIResponse,
@@ -36,8 +36,9 @@ export function mapToPostMIResponse(mi: MIBase): PostMIResponse {
 }
 
 export function mapToGetMIResponse(mi: MIBase): GetMIResponse {
-  return GetMIResponseResourceSchema.parse({
+  return GetMIResponseSchema.parse({
     data: {
+      id: mi.id,
       type: "ManagementInformation",
       attributes: {
         lineItem: mi.lineItem,
@@ -47,7 +48,6 @@ export function mapToGetMIResponse(mi: MIBase): GetMIResponse {
         groupId: mi.groupId,
         stockRemaining: mi.stockRemaining,
       },
-      id: mi.id,
     },
   });
 }