Fix terraform

Author: stevebux

infrastructure/terraform/components/api/README.md

@@ -38,6 +38,7 @@ No requirements.
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_allocation_lambda"></a> [allocation\_lambda](#module\_allocation\_lambda) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
+| <a name="module_amendments_queue"></a> [amendments\_queue](#module\_amendments\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-sqs.zip | n/a |
 | <a name="module_authorizer_lambda"></a> [authorizer\_lambda](#module\_authorizer\_lambda) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_domain_truststore"></a> [domain\_truststore](#module\_domain\_truststore) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_eventpub"></a> [eventpub](#module\_eventpub) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-eventpub.zip | n/a |
@@ -54,7 +55,6 @@ No requirements.
 | <a name="module_post_letters"></a> [post\_letters](#module\_post\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_post_mi"></a> [post\_mi](#module\_post\_mi) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_s3bucket_test_letters"></a> [s3bucket\_test\_letters](#module\_s3bucket\_test\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
-| <a name="module_sqs_letter_updates"></a> [sqs\_letter\_updates](#module\_sqs\_letter\_updates) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-sqs.zip | n/a |
 | <a name="module_supplier_requests_queue"></a> [supplier\_requests\_queue](#module\_supplier\_requests\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-sqs.zip | n/a |
 | <a name="module_supplier_ssl"></a> [supplier\_ssl](#module\_supplier\_ssl) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-ssl.zip | n/a |
 | <a name="module_upsert_letter"></a> [upsert\_letter](#module\_upsert\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |

infrastructure/terraform/components/api/event_source_mapping_status_updates_to_handler.tf

@@ -1,12 +1,12 @@
 resource "aws_lambda_event_source_mapping" "status_updates_sqs_to_status_update_handler" {
-  event_source_arn                   = module.letter_status_updates_queue.sqs_queue_arn
+  event_source_arn                   = module.supplier_requests_queue.sqs_queue_arn
   function_name                      = module.letter_status_update.function_arn
   batch_size                         = 10
   maximum_batching_window_in_seconds = 1
   scaling_config { maximum_concurrency = 10 }
 
   depends_on = [
-    module.letter_status_updates_queue, # ensures queue exists
-    module.letter_status_update         # ensures update handler exists
+    module.supplier_requests_queue, # ensures queue exists
+    module.letter_status_update     # ensures update handler exists
   ]
 }

infrastructure/terraform/components/api/module_lambda_patch_letter.tf

@@ -36,7 +36,7 @@ module "patch_letter" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = merge(local.common_lambda_env_vars, {
-    QUEUE_URL = module.letter_status_updates_queue.sqs_queue_url
+    QUEUE_URL = module.supplier_requests_queue.sqs_queue_url
   })
 }
 

infrastructure/terraform/components/api/module_lambda_post_letters.tf

@@ -36,7 +36,7 @@ module "post_letters" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = merge(local.common_lambda_env_vars, {
-    QUEUE_URL = module.letter_status_updates_queue.sqs_queue_url,
+    QUEUE_URL = module.supplier_requests_queue.sqs_queue_url,
     MAX_LIMIT = var.max_get_limit
   })
 }

infrastructure/terraform/components/api/module_sqs_amendments_queue.tf

@@ -1,4 +1,4 @@
-module "sqs_letter_updates" {
+module "amendments_queue" {
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-sqs.zip"
 
   aws_account_id = var.aws_account_id

infrastructure/terraform/components/api/sns_topic_subscription_allocation_lambda.tf

@@ -1,5 +1,5 @@
 resource "aws_sns_topic_subscription" "allocation_lambda" {
-  topic_arn = aws_sns_topic.sns_topic_event_bus.arn
+  topic_arn = module.eventsub.sns_topic_event_bus.arn
   protocol  = "lambda"
   endpoint  = module.allocation_lambda.function_arn
 }
@@ -9,5 +9,5 @@ resource "aws_lambda_permission" "allocation_lambda_sns" {
   action        = "lambda:InvokeFunction"
   function_name = module.allocation_lambda.function_name
   principal     = "sns.amazonaws.com"
-  source_arn    = aws_sns_topic.sns_topic_event_bus.arn
+  source_arn    = module.eventsub.sns_topic_event_bus.arn
 }