Add guard to non insert events

Author: nhsd-david-wass

infrastructure/terraform/components/api/README.md

@@ -50,9 +50,9 @@ No requirements.
 | <a name="module_letter_updates_transformer"></a> [letter\_updates\_transformer](#module\_letter\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
 | <a name="module_logging_bucket"></a> [logging\_bucket](#module\_logging\_bucket) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_mi_updates_transformer"></a> [mi\_updates\_transformer](#module\_mi\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
-| <a name="module_patch_letter"></a> [patch\_letter](#module\_patch\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
-| <a name="module_post_letters"></a> [post\_letters](#module\_post\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
-| <a name="module_post_mi"></a> [post\_mi](#module\_post\_mi) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
+| <a name="module_patch_letter"></a> [patch\_letter](#module\_patch\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
+| <a name="module_post_letters"></a> [post\_letters](#module\_post\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
+| <a name="module_post_mi"></a> [post\_mi](#module\_post\_mi) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
 | <a name="module_s3bucket_test_letters"></a> [s3bucket\_test\_letters](#module\_s3bucket\_test\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_sqs_letter_updates"></a> [sqs\_letter\_updates](#module\_sqs\_letter\_updates) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-sqs.zip | n/a |
 | <a name="module_supplier_ssl"></a> [supplier\_ssl](#module\_supplier\_ssl) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-ssl.zip | n/a |

lambdas/mi-updates-transformer/src/__tests__/mi-updates-transformer.test.ts

@@ -9,7 +9,7 @@ import {
 } from "aws-lambda";
 import { mockDeep } from "jest-mock-extended";
 import { MI } from "@internal/datastore";
-import { createHandler } from "../mi-updates-transformer";
+import createHandler from "../mi-updates-transformer";
 import { Deps } from "../deps";
 import { EnvVars } from "../env";
 import { mapMIToCloudEvent } from "../mappers/mi-mapper";
@@ -69,6 +69,29 @@ function generateInsertRecord(newMI: MI): DynamoDBRecord {
   };
 }
 
+function generateDeleteRecord(oldMI: MI): DynamoDBRecord {
+  const oldImage = Object.fromEntries(
+    Object.entries(oldMI).map(([key, value]) => [key, toAttr(value)]),
+  );
+  return {
+    eventName: "REMOVE",
+    dynamodb: { OldImage: oldImage },
+  };
+}
+
+function generateModifyRecord(oldMI: MI, newMI: MI): DynamoDBRecord {
+  const oldImage = Object.fromEntries(
+    Object.entries(oldMI).map(([key, value]) => [key, toAttr(value)]),
+  );
+  const newImage = Object.fromEntries(
+    Object.entries(newMI).map(([key, value]) => [key, toAttr(value)]),
+  );
+  return {
+    eventName: "MODIFY",
+    dynamodb: { OldImage: oldImage, NewImage: newImage },
+  };
+}
+
 describe("mi-updates-transformer Lambda", () => {
   const mockedDeps: jest.Mocked<Deps> = {
     snsClient: { send: jest.fn() } as unknown as SNSClient,
@@ -122,6 +145,28 @@ describe("mi-updates-transformer Lambda", () => {
     expect(mockedDeps.snsClient.send).not.toHaveBeenCalled();
   });
 
+  it("does not publish modify data", async () => {
+    const handler = createHandler(mockedDeps);
+    const miEvents = generateMIEvents(2);
+
+    const updateMI = generateModifyRecord(miEvents[0], miEvents[1]);
+    const testData = generateKinesisEvent([updateMI]);
+    await handler(testData, mockDeep<Context>(), jest.fn());
+
+    expect(mockedDeps.snsClient.send).not.toHaveBeenCalled();
+  });
+
+  it("does not publish delete data", async () => {
+    const handler = createHandler(mockedDeps);
+    const miEvents = generateMIEvents(2);
+
+    const deleteMI = generateDeleteRecord(miEvents[0]);
+    const testData = generateKinesisEvent([deleteMI]);
+    await handler(testData, mockDeep<Context>(), jest.fn());
+
+    expect(mockedDeps.snsClient.send).not.toHaveBeenCalled();
+  });
+
   it("batches mutiple records into a single call to SNS", async () => {
     const handler = createHandler(mockedDeps);
     const miEvents = generateMIEvents(10);

lambdas/mi-updates-transformer/src/index.ts

@@ -1,4 +1,4 @@
-import { createHandler } from "./mi-updates-transformer";
+import createHandler from "./mi-updates-transformer";
 import { createDependenciesContainer } from "./deps";
 
 const container = createDependenciesContainer();

lambdas/mi-updates-transformer/src/mi-updates-transformer.ts

@@ -13,6 +13,7 @@ import {
 import { MISubmittedEvent } from "@nhsdigital/nhs-notify-event-schemas-supplier-api/src";
 import { mapMIToCloudEvent } from "./mappers/mi-mapper";
 import { Deps } from "./deps";
+
 // SNS PublishBatchCommand supports up to 10 messages per batch
 const BATCH_SIZE = 10;
 
@@ -48,13 +49,14 @@ function extractMIData(record: DynamoDBRecord): MI {
   return MISchema.parse(unmarshall(newImage as any));
 }
 
-export function createHandler(deps: Deps): Handler<KinesisStreamEvent> {
+export default function createHandler(deps: Deps): Handler<KinesisStreamEvent> {
   return async (streamEvent: KinesisStreamEvent) => {
     deps.logger.info({ description: "Received event", streamEvent });
 
     const cloudEvents: MISubmittedEvent[] = streamEvent.Records.map((record) =>
       extractPayload(record, deps),
     )
+      .filter((record) => record.eventName === "INSERT")
       .map((element) => extractMIData(element))
       .map((payload) => mapMIToCloudEvent(payload, deps));