review fix

Author: Namitha-Prabhu

tests/helpers/generate-fetch-test-data.ts

@@ -168,7 +168,7 @@ export async function createSupplierEntry(supplierId: string): Promise<void> {
 export async function checkLetterQueueTable(
   supplierId: string,
   letterId: string,
-  deleteAfterCheck?: boolean,
+  checkForDeletedLetters?: boolean,
 ): Promise<[boolean, number?]> {
   const MAX_ATTEMPTS = 5;
   const RETRY_DELAY_MS = 10_000;
@@ -185,13 +185,13 @@ export async function checkLetterQueueTable(
 
     for (let attempt = 1; attempt <= MAX_ATTEMPTS; attempt++) {
       const { Items } = await docClient.send(new QueryCommand(params));
-      if (!deleteAfterCheck && Items !== undefined && Items.length > 0) {
+      if (!checkForDeletedLetters && Items !== undefined && Items.length > 0) {
         logger.info(
           `Queried letter queue table to verify existence for letterId ${letterId} and found items, confirming existence`,
         );
         return [true, Items.length];
       }
-      if (deleteAfterCheck && Items !== undefined && Items.length === 0) {
+      if (checkForDeletedLetters && Items !== undefined && Items.length === 0) {
         logger.info(
           `Queried letter queue table to verify deletion for letterId ${letterId} and found no items, confirming deletion`,
         );

tests/helpers/poll-for-letters-helper.ts

@@ -49,16 +49,7 @@ async function pollForLetterStatus(
   return { letterStatus, statusCode };
 }
 
-export async function pollForLettersInDb(
-  request: APIRequestContext,
-  supplierId: string,
-  domainId: string,
-  baseUrl: string,
-): Promise<{ letterStatus: string | undefined; statusCode: number }> {
-  return pollForLetterStatus(request, supplierId, domainId, baseUrl);
-}
-
-export async function getLetterStatusFromApi(
+export async function pollForLetterInDb(
   request: APIRequestContext,
   supplierId: string,
   domainId: string,