Another test fix

Author: stevebux

tests/component-tests/events-tests/event-subscription.spec.ts

@@ -104,16 +104,13 @@ test.describe("Event Subscription SNS Tests", () => {
     );
   });
 
-  test("Verify that the duplicate event throws an error", async () => {
+  test("Verify that an error is logged for a duplicate letter id", async () => {
     const domainId = randomUUID();
     logger.info(`Testing event subscription with domainId: ${domainId}`);
-    const preparedEvent = createPreparedV1Event({
-      domainId,
-      status: "PREPARED",
-    });
-    const response = await sendSnsEvent(preparedEvent);
+    const preparedEvent1 = createPreparedV1Event({ domainId });
+    const response1 = await sendSnsEvent(preparedEvent1);
 
-    expect(response.MessageId).toBeTruthy();
+    expect(response1.MessageId).toBeTruthy();
 
     // poll supplier allocator to check if supplier has been allocated
     const message = await pollSupplierAllocatorLogForResolvedSpec(domainId);
@@ -129,11 +126,11 @@ test.describe("Event Subscription SNS Tests", () => {
       throw new Error("supplierId was not found in supplier allocator log");
     }
 
-    // send same event again to simulate duplicate event
-    const duplicateResponse = await sendSnsEvent(preparedEvent);
-    expect(duplicateResponse.MessageId).toBeTruthy();
+    const preparedEvent2 = createPreparedV1Event({ domainId });
+    const response2 = await sendSnsEvent(preparedEvent2);
+    expect(response2.MessageId).toBeTruthy();
 
-    // poll supplier upsert to check if duplicate event was processed
+    // poll supplier upsert to check if duplicate letter id was processed
     await pollUpsertLetterLogForWarning("Letter already exists", domainId);
   });
 });