Link supplier topic to amendments queue

Author: stevebux

infrastructure/terraform/components/api/README.md

@@ -38,8 +38,8 @@ No requirements.
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_allocation_lambda"></a> [allocation\_lambda](#module\_allocation\_lambda) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
-| <a name="module_amendments_queue"></a> [amendments\_queue](#module\_amendments\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-sqs.zip | n/a |
+| <a name="module_allocation_lambda"></a> [allocation\_lambda](#module\_allocation\_lambda) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
+| <a name="module_amendments_queue"></a> [amendments\_queue](#module\_amendments\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-sqs.zip | n/a |
 | <a name="module_authorizer_lambda"></a> [authorizer\_lambda](#module\_authorizer\_lambda) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
 | <a name="module_domain_truststore"></a> [domain\_truststore](#module\_domain\_truststore) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_eventpub"></a> [eventpub](#module\_eventpub) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-eventpub.zip | n/a |
@@ -50,7 +50,6 @@ No requirements.
 | <a name="module_get_status"></a> [get\_status](#module\_get\_status) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
 | <a name="module_kms"></a> [kms](#module\_kms) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-kms.zip | n/a |
 | <a name="module_letter_status_update"></a> [letter\_status\_update](#module\_letter\_status\_update) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
-| <a name="module_letter_status_updates_queue"></a> [letter\_status\_updates\_queue](#module\_letter\_status\_updates\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-sqs.zip | n/a |
 | <a name="module_letter_updates_transformer"></a> [letter\_updates\_transformer](#module\_letter\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |
 | <a name="module_logging_bucket"></a> [logging\_bucket](#module\_logging\_bucket) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_patch_letter"></a> [patch\_letter](#module\_patch\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.29/terraform-lambda.zip | n/a |

infrastructure/terraform/components/api/module_sqs_amendments_queue.tf

@@ -35,13 +35,14 @@ data "aws_iam_policy_document" "letter_updates_queue_policy" {
     ]
 
     resources = [
-      "arn:aws:sqs:${var.region}:${var.aws_account_id}:${var.project}-${var.environment}-${var.component}-letter-updates-queue"
+      module.amendments_queue.arn,
     ]
 
     condition {
       test     = "ArnEquals"
       variable = "aws:SourceArn"
-      values   = [module.eventsub.sns_topic_event_bus.arn]
+      values   = [module.eventsub.sns_topic_event_bus.arn, module.eventsub.sns_topic_supplier.arn]
+
     }
   }
 

lambdas/api-handler/src/services/__tests__/letter-operations.test.ts

@@ -247,7 +247,7 @@ describe("enqueueLetterUpdateRequests function", () => {
             reasonCode: lettersToUpdate[0].reasonCode,
             reasonText: lettersToUpdate[0].reasonText,
           }),
-          MessageGroupId: updateLetterCommands[0].id,
+          MessageGroupId: lettersToUpdate[0].id,
         },
       }),
     );
@@ -268,7 +268,7 @@ describe("enqueueLetterUpdateRequests function", () => {
             status: lettersToUpdate[1].status,
             supplierId: lettersToUpdate[1].supplierId,
           }),
-          MessageGroupId: updateLetterCommands[1].id,
+          MessageGroupId: lettersToUpdate[1].id,
         },
       }),
     );
@@ -312,7 +312,7 @@ describe("enqueueLetterUpdateRequests function", () => {
             status: lettersToUpdate[1].status,
             supplierId: lettersToUpdate[1].supplierId,
           }),
-          MessageGroupId: updateLetterCommands[1].id,
+          MessageGroupId: lettersToUpdate[1].id,
         },
       }),
     );