Skip to content

Commit f935c9b

Browse files
merge feature/CCM-12997 into my branch
2 parents a76a0fe + 63bd2f7 commit f935c9b

3 files changed

Lines changed: 18 additions & 7 deletions

File tree

.github/workflows/stage-4-acceptance.yaml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,15 @@ jobs:
5353
registry-url: "https://npm.pkg.github.com"
5454
scope: "@nhsdigital"
5555

56+
- name: "Set environment"
57+
shell: bash
58+
run: |
59+
if [ "${{ inputs.pr_number }}" != "" ]; then
60+
echo "ENVIRONMENT=pr${{ inputs.pr_number }}" >> $GITHUB_ENV
61+
else
62+
echo "ENVIRONMENT=main" >> $GITHUB_ENV
63+
fi
64+
5665
- name: Trigger Acceptance Tests
5766
shell: bash
5867
env:
@@ -65,6 +74,6 @@ jobs:
6574
--infraRepoName "nhs-notify-supplier-api" \
6675
--releaseVersion "${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" \
6776
--overrideProjectName "nhs" \
68-
--targetEnvironment "pr${{ inputs.pr_number }}" \
77+
--targetEnvironment "$ENVIRONMENT" \
6978
--targetAccountGroup "nhs-notify-supplier-api-dev" \
7079
--targetComponent "api"

.gitleaksignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,5 @@ debc75a97cfe551a69fd1e8694be483213322a9d:pact-contracts/pacts/letter-rendering/s
2424
793b2ab7a3e698f5848fbe24d2718f88664ec0fc:.npmrc:npm-access-token:8
2525
793b2ab7a3e698f5848fbe24d2718f88664ec0fc:.npmrc:github-pat:6
2626
777eb4047ad06b9e939a292ee18664a0ffee4f29:tests/resources/prepared-letter.json:generic-api-key:4
27+
d005112adcfd286c3bef076214836dbb2fe8d0b5:.npmrc:github-pat:7
28+
d005112adcfd286c3bef076214836dbb2fe8d0b5:.npmrc:npm-access-token:9

infrastructure/terraform/components/api/variables.tf

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,6 @@ variable "eventpub_control_plane_bus_arn" {
141141
default = ""
142142
}
143143

144-
variable "disable_gateway_execute_endpoint" {
145-
type = bool
146-
description = "Disable the execution endpoint for the API Gateway"
147-
default = true
148-
}
149-
150144
variable "letter_variant_map" {
151145
type = map(object({ supplierId = string, specId = string }))
152146
default = {
@@ -156,6 +150,12 @@ variable "letter_variant_map" {
156150
}
157151
}
158152

153+
variable "disable_gateway_execute_endpoint" {
154+
type = bool
155+
description = "Disable the execution endpoint for the API Gateway"
156+
default = true
157+
}
158+
159159
variable "core_account_id" {
160160
type = string
161161
description = "AWS Account ID for Core"

0 commit comments

Comments
 (0)