tidy up

Author: stevebux

tests/helpers/event-fixtures.ts

@@ -14,23 +14,21 @@ export function createPreparedV1Event(overrides: Record<string, unknown> = {}) {
       "https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.1.0.0.schema.json",
     dataschemaversion: "1.0.0",
     data: {
-      domainId:
-        (overrides.domainId as string) ??
-        "fe658e11-0ffc-44f4-8ad6-0fafe75bfeee",
-      letterVariantId:
-        (overrides.letterVariantId as string) ?? "digitrials-aspiring",
+      domainId: "fe658e11-0ffc-44f4-8ad6-0fafe75bfeee",
+      letterVariantId: "digitrials-aspiring",
       requestId: "request1",
       requestItemId: "requestItem1",
       requestItemPlanId: "requestItemPlan1",
       clientId: "client1",
       campaignId: "campaign1",
       templateId: "template1",
-      url: (overrides.url as string) ?? "s3://letterDataBucket/letter1.pdf",
+      url: "s3://letterDataBucket/letter1.pdf",
       sha256Hash:
         "3a7bd3e2360a3d29eea436fcfb7e44c735d117c8f2f1d2d1e4f6e8f7e6e8f7e6",
       createdAt: now,
       pageCount: 1,
-      status: (overrides.status as string) ?? "PREPARED",
+      status: "PREPARED",
+      ...overrides,
     },
     traceparent: "00-0af7651916cd43dd8448eb211c803191-b7ad6b7169203331-01",
     recordedtime: now,