Skip to content

Commit 3829e63

Browse files
committed
fix package version parameter support when creating runtime package. Set the correct package version in result package.json file
1 parent 118879c commit 3829e63

2 files changed

Lines changed: 27 additions & 19 deletions

File tree

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ env:
22
global:
33
- NDK_VERSION=r11c
44
- DATE=$(date +%Y-%m-%d)
5-
- PACKAGE_VERSION=$DATE-$TRAVIS_BUILD_NUMBER
5+
- PACKAGE_VERSION=next-$DATE-$TRAVIS_BUILD_NUMBER
66
- PACKAGE_NAME=tns-android
77
sudo: false
88
language: android

build.gradle

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ task checkEnvironmentVariables {
3333
logger.warn("Warning: The GIT_COMMIT is not set. This NativeScript Android Runtime will not be tagged with the git commit it is build from\n");
3434
}
3535

36-
if(project.hasProperty("devmode") == true && !project.hasProperty("metadataGenSrc") && !file("../android-metadata-generator").exists()) {
37-
throw new GradleException("../android-metadata-generator directory not found and no metadataGenSrc option specified. Clone the android-metadata-generator repo first.\n");
38-
}
39-
4036
if(project.hasProperty("metadataGen") && !file("../android-metadata-generator/dist/tns-android-metadata-generator-0.0.1.tgz").exists()) {
4137
throw new GradleException("android-metadata-generator build output not found and no metadataGen option specified. Build android-metadata-generator first.\n");
4238
}
@@ -62,19 +58,29 @@ task copyPackageJson (type: Copy) {
6258
}
6359

6460
task getPackageVersion << {
65-
String content = new File("$rootDir/package.json").getText("UTF-8")
66-
def jsonSlurper = new JsonSlurper()
67-
def packageJsonMap = jsonSlurper.parseText(content)
68-
69-
pVersion = packageJsonMap.version
61+
62+
if (project.hasProperty("packageVersion")) {
63+
pVersion = packageVersion
64+
65+
println "Using packageVersion property '${pVersion}'"
66+
}
67+
else {
68+
String content = new File("$rootDir/package.json").getText("UTF-8")
69+
def jsonSlurper = new JsonSlurper()
70+
def packageJsonMap = jsonSlurper.parseText(content)
7071

71-
println "The package version from package.json is '${pVersion}'"
72+
pVersion = packageJsonMap.version
73+
74+
println "Using runtime version from package.json '${pVersion}'"
75+
}
7276

7377
if (project.hasProperty("preReleaseVersion")) {
7478
pVersion += "-" + preReleaseVersion
79+
80+
println "Adding preReleaseVersion property '${pVersion}' to package version"
7581
}
7682

77-
println "The runtime version is '${pVersion}'"
83+
println "The package version is '${pVersion}'"
7884
}
7985

8086
task getCommitVersion << {
@@ -153,13 +159,12 @@ task createNpmPackage (type: Exec) {
153159
}
154160

155161
task setPackageVersionInPackageJsonFile << {
156-
if (project.hasProperty("packageVersion")) {
162+
157163
def inputFile = new File("$rootDir/dist/package.json")
158164
def json = new JsonSlurper().parseText(inputFile.text)
159-
json.version = json.version + "-" + packageVersion
165+
json.version = pVersion
160166
def jb = new JsonBuilder(json);
161167
inputFile.text = JsonOutput.prettyPrint(jb.toString())
162-
}
163168
}
164169

165170
task copyReadme (type: Copy) {
@@ -174,15 +179,17 @@ createDistDir.dependsOn(cleanDistDir)
174179
//copy framework structure
175180
copyProjectTemplate.dependsOn(createDistDir)
176181
copyPackageJson.dependsOn(copyProjectTemplate)
177-
setPackageVersionInPackageJsonFile.dependsOn(copyPackageJson)
182+
178183

179184
//get version from package json
180-
getPackageVersion.dependsOn(setPackageVersionInPackageJsonFile)
185+
getPackageVersion.dependsOn(copyProjectTemplate)
181186
getCommitVersion.dependsOn(getPackageVersion)
182187

183188
//generate runtime and copy into framework structure
184189
generateRuntime.dependsOn(getCommitVersion)
185190

191+
setPackageVersionInPackageJsonFile.dependsOn(generateRuntime)
192+
186193
//generateRuntime.dependsOn(build)
187194

188195
tasks.whenTaskAdded { task ->
@@ -202,7 +209,7 @@ copyGeneratedMetadataGeneratorJar.dependsOn(generateMetadataGeneratorJar)
202209
copyReadme.dependsOn(copyGeneratedMetadataGeneratorJar)
203210

204211
//pack runtime
205-
createNpmPackage.dependsOn(copyReadme)
212+
createNpmPackage.dependsOn(copyReadme, setPackageVersionInPackageJsonFile)
206213

207214
task createPackage {
208215
description "Builds the NativeScript Android App Package using an application project template."
@@ -211,13 +218,14 @@ task createPackage {
211218
copyProjectTemplate,
212219

213220
copyPackageJson,
214-
setPackageVersionInPackageJsonFile,
215221

216222
getPackageVersion,
217223
getCommitVersion,
218224

219225
generateRuntime,
220226

227+
setPackageVersionInPackageJsonFile,
228+
221229
copyGeneratedRuntime,
222230
copyBindingGeneratorLib,
223231
generateMetadataGeneratorJar,

0 commit comments

Comments
 (0)