Add support to implement Java interfaces via extend keyword (issue #514

Author: Mihail Slavchev

runtime/src/main/jni/CallbackHandlers.cpp

@@ -155,9 +155,9 @@ jclass CallbackHandlers::ResolveClass(Isolate *isolate, const string& fullClassn
 }
 
 // Called by ExtendCallMethodCallback when extending a class
-string CallbackHandlers::ResolveClassName(Isolate *isolate, const string& fullClassname, const Local<Object>& implementationObject)
+string CallbackHandlers::ResolveClassName(Isolate *isolate, const string& fullClassname, const Local<Object>& implementationObject, bool isInterface)
 {
-	auto clazz = ResolveClass(isolate, fullClassname, implementationObject, false);
+	auto clazz = ResolveClass(isolate, fullClassname, implementationObject, isInterface);
 	auto runtime = Runtime::GetRuntime(isolate);
 	auto objectManager = runtime->GetObjectManager();
 	auto className = objectManager->GetClassName(clazz);

runtime/src/main/jni/CallbackHandlers.h

@@ -32,7 +32,7 @@ namespace tns
 
 			static jclass ResolveClass(v8::Isolate *isolate, const std::string& fullClassname, const v8::Local<v8::Object>& implementationObject, bool isInterface);
 
-			static std::string ResolveClassName(v8::Isolate *isolate, const std::string& fullClassname, const v8::Local<v8::Object>& implementationObject);
+			static std::string ResolveClassName(v8::Isolate *isolate, const std::string& fullClassname, const v8::Local<v8::Object>& implementationObject, bool isInterface);
 
 			static v8::Local<v8::Value> GetArrayElement(v8::Isolate *isolate, const v8::Local<v8::Object>& array, uint32_t index, const std::string& arraySignature);
 

runtime/src/main/jni/MetadataNode.cpp

@@ -1502,7 +1502,9 @@ void MetadataNode::ExtendCallMethodCallback(const v8::FunctionCallbackInfo<v8::V
 		auto isolate = info.GetIsolate();
 
 		//resolve class (pre-generated or generated runtime from dex generator)
-		auto fullExtendedName = CallbackHandlers::ResolveClassName(isolate, fullClassName, implementationObject);
+		uint8_t nodeType = s_metadataReader.GetNodeType(node->m_treeNode);
+		bool isInterface = s_metadataReader.IsNodeTypeInterface(nodeType);
+		auto fullExtendedName = CallbackHandlers::ResolveClassName(isolate, fullClassName, implementationObject, isInterface);
 		DEBUG_WRITE("ExtendsCallMethodHandler: extend full name %s", fullClassName.c_str());
 
 		auto cachedData = GetCachedExtendedClassData(isolate, fullExtendedName);

test-app/app/src/main/assets/app/tests/tests.js

@@ -1687,4 +1687,17 @@ describe("Tests ", function () {
 
 		expect(exceptionCaught).toBe(true);
 	});
+
+    it("should implement an interface using extend keyword", function () {
+        var called = false;
+        var R = java.lang.Runnable.extend({
+            run: function() {
+                called = true;
+            }
+        });
+
+        new R().run();
+
+        expect(called).toBe(true);
+    });
 });