Skip to content

Commit d23d450

Browse files
author
Mihail Slavchev
committed
remove unused code
1 parent bb5ccc1 commit d23d450

3 files changed

Lines changed: 0 additions & 39 deletions

File tree

src/jni/ArgConverter.cpp

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -290,32 +290,6 @@ int64_t ArgConverter::ConvertToJavaLong(const Local<Value>& value)
290290
return longValue;
291291
}
292292

293-
bool ArgConverter::TryConvertToJavaLong(const Local<Value>& value, jlong& javaLong)
294-
{
295-
bool success = false;
296-
297-
if (!value.IsEmpty())
298-
{
299-
if (value->IsNumber() || value->IsNumberObject())
300-
{
301-
javaLong = (jlong) value->IntegerValue();
302-
success = true;
303-
}
304-
else if (value->IsObject())
305-
{
306-
auto obj = Local<Object>::Cast(value);
307-
auto isJavaLongValue = obj->GetHiddenValue(V8StringConstants::GetJavaLong());
308-
if (!isJavaLongValue.IsEmpty() && isJavaLongValue->BooleanValue())
309-
{
310-
javaLong = (jlong) ConvertToJavaLong(value);
311-
success = true;
312-
}
313-
}
314-
}
315-
316-
return success;
317-
}
318-
319293
JavaVM* ArgConverter::jvm = nullptr;
320294
Persistent<Function>* ArgConverter::NATIVESCRIPT_NUMBER_CTOR_FUNC = nullptr;
321295
Persistent<NumberObject>* ArgConverter::NAN_NUMBER_OBJECT = nullptr;

src/jni/ArgConverter.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ namespace tns
2525

2626
static int64_t ConvertToJavaLong(const v8::Local<v8::Value>& value);
2727

28-
static bool TryConvertToJavaLong(const v8::Local<v8::Value>& value, jlong& javaLong);
29-
3028
static v8::Local<v8::Value> jstringToV8String(jstring value);
3129

3230
static std::string jstringToString(jstring value);

src/jni/JsArgConverter.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -215,17 +215,6 @@ bool JsArgConverter::ConvertArg(const Local<Value>& arg, int index)
215215
default:
216216
throw NativeScriptException("Unsupported cast type");
217217
}
218-
219-
// auto hidden = jsObject->GetHiddenValue(V8StringConstants::GetMarkedAsLong());
220-
// if (!hidden.IsEmpty())
221-
// {
222-
// }
223-
// else if (ArgConverter::TryConvertToJavaLong(jsObject, javaLongValue))
224-
// {
225-
// m_args[index].j = javaLongValue;
226-
// success = true;
227-
// return success;
228-
// }
229218
}
230219
else if (arg->IsUndefined() || arg->IsNull())
231220
{

0 commit comments

Comments
 (0)