Skip to content

Commit e9ba8b3

Browse files
Gupta, SuryaLocharla, Sandeep
authored andcommitted
CSTACKEX-46 Change log level
1 parent f1b7dbd commit e9ba8b3

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ void deleteCloudStackVolume(CloudStackVolume cloudstackVolume) {
107107

108108
@Override
109109
public CloudStackVolume getCloudStackVolume(Map<String, String> values) {
110-
s_logger.info("getCloudStackVolume : fetching Lun with params {} ", values);
110+
s_logger.info("getCloudStackVolume : fetching Lun");
111+
s_logger.debug("getCloudStackVolume : fetching Lun with params {} ", values);
111112
if (values == null || values.isEmpty()) {
112113
s_logger.error("getCloudStackVolume: get Lun failed. Invalid request: {}", values);
113114
throw new CloudRuntimeException("getCloudStackVolume : get Lun Failed, invalid request");
@@ -144,9 +145,10 @@ public CloudStackVolume getCloudStackVolume(Map<String, String> values) {
144145
@Override
145146
public AccessGroup createAccessGroup(AccessGroup accessGroup) {
146147
s_logger.info("createAccessGroup : Create Igroup");
147-
String igroupName = "unknown";
148-
if (accessGroup == null) {
149-
throw new CloudRuntimeException("createAccessGroup : Failed to create Igroup, invalid accessGroup object passed");
148+
s_logger.debug("createAccessGroup : Creating Igroup with access group request {} ", accessGroup);
149+
if (accessGroup == null || accessGroup.getIgroup() == null) {
150+
s_logger.error("createAccessGroup: Igroup creation failed. Invalid request: {}", accessGroup);
151+
throw new CloudRuntimeException("createAccessGroup : Failed to create Igroup, invalid request");
150152
}
151153
try {
152154
// Get StoragePool details
@@ -340,7 +342,8 @@ public AccessGroup updateAccessGroup(AccessGroup accessGroup) {
340342
}
341343

342344
public AccessGroup getAccessGroup(Map<String, String> values) {
343-
s_logger.info("getAccessGroup : fetching Igroup with params {} ", values);
345+
s_logger.info("getAccessGroup : fetch Igroup");
346+
s_logger.debug("getAccessGroup : fetching Igroup with params {} ", values);
344347
if (values == null || values.isEmpty()) {
345348
s_logger.error("getAccessGroup: get Igroup failed. Invalid request: {}", values);
346349
throw new CloudRuntimeException("getAccessGroup : get Igroup Failed, invalid request");
@@ -372,7 +375,8 @@ public AccessGroup getAccessGroup(Map<String, String> values) {
372375
}
373376

374377
public void enableLogicalAccess(Map<String, String> values) {
375-
s_logger.info("enableLogicalAccess : Creating LunMap with values {} ", values);
378+
s_logger.info("enableLogicalAccess : Create LunMap");
379+
s_logger.debug("enableLogicalAccess : Creating LunMap with values {} ", values);
376380
LunMap lunMapRequest = new LunMap();
377381
String svmName = values.get(Constants.SVM_DOT_NAME);
378382
String lunName = values.get(Constants.LUN_DOT_NAME);
@@ -400,7 +404,8 @@ public void enableLogicalAccess(Map<String, String> values) {
400404
}
401405

402406
public void disableLogicalAccess(Map<String, String> values) {
403-
s_logger.info("disableLogicalAccess : Deleting LunMap with values {} ", values);
407+
s_logger.info("disableLogicalAccess : Delete LunMap");
408+
s_logger.debug("disableLogicalAccess : Deleting LunMap with values {} ", values);
404409
String lunUUID = values.get(Constants.LUN_DOT_UUID);
405410
String igroupUUID = values.get(Constants.IGROUP_DOT_UUID);
406411
if(lunUUID == null || igroupUUID == null || lunUUID.isEmpty() || igroupUUID.isEmpty()) {

0 commit comments

Comments
 (0)