Minor code cleanup to one method in Utils and removal of some commented

out printlns.

Author: Dave Wichers

src/main/java/org/owasp/benchmark/helpers/LDAPManager.java

@@ -112,19 +112,20 @@ private boolean search(LDAPPerson person) {
 
             NamingEnumeration<SearchResult> results = ctx.search(base, filter, sc);
 
+            boolean foundUser = results.hasMore();
+
             while (results.hasMore()) {
                 SearchResult sr = (SearchResult) results.next();
                 Attributes attrs = sr.getAttributes();
 
                 Attribute attr = attrs.get("uid");
                 if (attr != null) {
-                    // logger.debug("record found " + attr.get());
                     // System.out.println("record found " + attr.get());
                 }
             }
             ctx.close();
 
-            return true;
+            return foundUser;
         } catch (Exception e) {
             System.out.println("LDAP error search: ");
             e.printStackTrace();

src/main/java/org/owasp/benchmark/helpers/Utils.java

@@ -236,8 +236,6 @@ public static void printOSCommandResults(java.lang.Process proc, HttpServletResp
 
         try {
             // read the output from the command
-            // System.out.println("Here is the standard output of the
-            // command:\n");
             out.write("Here is the standard output of the command:<br>");
             String s = null;
             while ((s = stdInput.readLine()) != null) {
@@ -246,8 +244,6 @@ public static void printOSCommandResults(java.lang.Process proc, HttpServletResp
             }
 
             // read any errors from the attempted command
-            // System.out.println("Here is the standard error of the command (if
-            // any):\n");
             out.write("<br>Here is the std err of the command (if any):<br>");
             while ((s = stdError.readLine()) != null) {
                 out.write(ESAPI.encoder().encodeForHTML(s));