cleaned up and added more tests

Author: SharePointRadi

src/OneBitSoftware.Utilities.OperationResult/OperationResultJsonConverter.cs

@@ -11,7 +11,6 @@ namespace OneBitSoftware.Utilities
     public class OperationResultJsonConverter : JsonConverter<OperationResult>
     {
         private readonly Dictionary<string, Type> _valueMappings = new Dictionary<string, Type>();
-        private readonly Dictionary<Type, string> _typeMappings = new Dictionary<Type, string>();
 
         public OperationResultJsonConverter()
         {
@@ -41,10 +40,9 @@ public override bool CanConvert(Type typeToConvert)
         protected bool AddMapping(string typeValue, Type type)
         {
             if (string.IsNullOrWhiteSpace(typeValue) || type is null) return false;
-            if (this._valueMappings.ContainsKey(typeValue) || this._typeMappings.ContainsKey(type)) return false;
+            if (this._valueMappings.ContainsKey(typeValue)) return false;
 
             this._valueMappings[typeValue] = type;
-            this._typeMappings[type] = typeValue;
             return true;
         }
 
@@ -151,7 +149,6 @@ public virtual void AppendErrorType(JsonElement element, Type mappedType, Operat
                 }
             }
 
-            // TODO
             private JsonSerializerOptions ConstructSafeFallbackOptions(JsonSerializerOptions options)
             {
                 var fallbackSerializationOptions = new JsonSerializerOptions(options);

tests/OneBitSoftware.Utilities.OperationResultTests/CustomErrorTests.cs

@@ -11,11 +11,25 @@ namespace OneBitSoftware.Utilities.OperationResultTests
     public class CustomErrorTests
     {
         [Fact]
-        public void TestCustomError()
+        public void CustomError_CanInstantiate()
         {
-            var c = new CustomError();
-            var c1 = typeof(CustomError).IsAssignableFrom(typeof(IOperationError));
-            var c2 = typeof(IOperationError).IsAssignableFrom(typeof(CustomError));
+            var customError = new CustomError();
+
+            Assert.NotNull(customError);
+        }
+
+        [Fact]
+        public void CustomError_IsIOperationError()
+        {
+            Assert.True(typeof(IOperationError).IsAssignableFrom(typeof(CustomError)));
+        }
+
+        [Fact]
+        public void CustomError_IsOperationError()
+        {
+            var customError = new CustomError();
+
+            Assert.True(typeof(OperationError).IsInstanceOfType(customError));
         }
     }
 }