comments

Author: SharePointRadi

src/OneBitSoftware.Utilities.OperationResult/OperationResult.cs

@@ -3,7 +3,7 @@
     using System;
     using System.Collections.Generic;
     using System.Linq;
-using System.Text.Json.Serialization;
+    using System.Text.Json.Serialization;
     using Microsoft.Extensions.Logging;
     using OneBitSoftware.Utilities.Errors;
 

tests/OneBitSoftware.Utilities.OperationResultTests/Serialization/CustomErrorPolymorphicDeserializer.cs

@@ -4,6 +4,7 @@
     using System.Text.Json;
     using OneBitSoftware.Utilities.Errors;
 
+    // TODO: unify with the serializer
     /// <summary>
     /// A <see cref="System.Text.Json.Serialization.JsonConverter"/> inheriting class for polymorphic serialization.deserialization of custom <see cref="IOperationError"/> implementations.
     /// </summary>
@@ -15,23 +16,5 @@ public CustomErrorPolymorphicDeserializer() : base()
             AddMapping("custom_error", typeof(CustomError));
         }
 
-        //public override void WriteAdditionalElements(Utf8JsonWriter writer, string typeValue, IOperationError error)
-        //{
-        //    if (error != null && error is CustomError)
-        //    {
-        //        var customError = error as CustomError;
-        //        writer.WriteString(
-        //            propertyName: nameof(CustomError.CustomProperty),
-        //            value: String.IsNullOrEmpty(customError?.CustomProperty) ? string.Empty : customError.CustomProperty.ToString());
-        //    }
-        //}
-
-        //public override void AppendErrorType(JsonElement element, Type mappedType, OperationResult operationResult)
-        //{
-        //    if (mappedType.Equals("custom_error"))
-        //    {
-        //        operationResult.AppendError(this.ToObject<CustomError>(element));
-        //    }
-        //}
     }
 }

tests/OneBitSoftware.Utilities.OperationResultTests/Serialization/CustomErrorPolymorphicSerializer.cs

@@ -14,24 +14,5 @@ public CustomErrorPolymorphicSerializer() : base()
             // Define your discriminator and custom type mapping
             AddMapping("custom_error", typeof(CustomError));
         }
-
-        //public override void WriteAdditionalElements(Utf8JsonWriter writer, string typeValue, IOperationError error)
-        //{
-        //    if (error != null && error is CustomError)
-        //    {
-        //        var customError = error as CustomError;
-        //        writer.WriteString(
-        //            propertyName: nameof(CustomError.CustomProperty),
-        //            value: String.IsNullOrEmpty(customError?.CustomProperty) ? string.Empty : customError.CustomProperty.ToString());
-        //    }
-        //}
-
-        //public override void AppendErrorType(JsonElement element, Type mappedType, OperationResult operationResult)
-        //{
-        //    if (mappedType.Equals("custom_error"))
-        //    {
-        //        operationResult.AppendError(this.ToObject<CustomError>(element));
-        //    }
-        //}
     }
 }

tests/OneBitSoftware.Utilities.OperationResultTests/Serialization/OperationResultSerializationTests.cs

@@ -17,7 +17,6 @@ private JsonSerializerOptions GetSerializationOptions()
             var serializeOptions = new JsonSerializerOptions();
             serializeOptions.Converters.Add(new CustomErrorPolymorphicDeserializer());
             serializeOptions.Converters.Add(new CustomErrorPolymorphicSerializer());
-            // serializeOptions.Converters.Add(new PolymorphicOperationErrorListConverter<IList<IOperationError>>());
             return serializeOptions;
         }
 
@@ -146,6 +145,7 @@ public void CanSerializeAndDeserializeWithSystemTextJson()
         [Fact]
         public async Task CanSerializeAndDeserializeCustomErrorWithSystemTextJson()
         {
+            // TODO: clean up variables and repeated code
             // Arrange
             var testText = "Test details";
             var customErrorText = "Custom error test details";