Skip to content

Commit cda0215

Browse files
author
tgancheva
committed
Remove unnecessary method in operation result.
1 parent d1a41ee commit cda0215

2 files changed

Lines changed: 3 additions & 13 deletions

File tree

src/OneBitSoftware.Utilities.OperationResult/OperationResult.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ public OperationResult AppendErrors(OperationResult otherOperationResult)
102102
/// <returns>The current instance of the <see cref="OperationResult"/>.</returns>
103103
public OperationResult AppendError(string message, int errorCode = 0, LogLevel? logLevel = null)
104104
{
105-
if (message is null) throw new ArgumentNullException(nameof(message));
106105
if (string.IsNullOrWhiteSpace(message)) throw new ArgumentNullException(nameof(message));
107106

108107
var error = new OperationError(message, errorCode);
@@ -111,15 +110,6 @@ public OperationResult AppendError(string message, int errorCode = 0, LogLevel?
111110
return this;
112111
}
113112

114-
/// <summary>
115-
/// Appends an error message to the operation result instance.
116-
/// </summary>
117-
/// <param name="message">The message that should be appended.</param>
118-
/// <param name="errorCode">The unique code of the error.</param>
119-
/// <param name="logLevel">The logging severity.</param>
120-
/// <returns>The current instance of the <see cref="OperationResult"/>.</returns>
121-
public OperationResult AppendErrorMessage(string message, int errorCode = 0, LogLevel? logLevel = null) => this.AppendError(message, errorCode, logLevel);
122-
123113
/// <summary>
124114
/// Appends an exception to the error message collection and logs the full exception as an Error <see cref="LogEventLevel"/> level. A call to this method will set the Success property to false.
125115
/// </summary>

src/OneBitSoftware.Utilities.OperationResult/OperationResultValidationExtensions.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public static void ValidateDefault<T, TValue>(this OperationResult<T> operationR
5151
if (value.Equals(default) == false) return;
5252

5353
var errorMessage = $"{className}, {methodName} - The {propertyName} has a default value.";
54-
operationResult.AppendErrorMessage(errorMessage, logLevel: level);
54+
operationResult.AppendError(errorMessage, logLevel: level);
5555
}
5656

5757
/// <summary>
@@ -70,7 +70,7 @@ public static void ValidateNullOrWhitespace<T>(this OperationResult<T> operation
7070
if (string.IsNullOrWhiteSpace(value) == false) return;
7171

7272
var errorMessage = $"{className}, {methodName} - The {propertyName} is null, empty or consists only of whitespace characters.";
73-
operationResult.AppendErrorMessage(errorMessage, logLevel: level);
73+
operationResult.AppendError(errorMessage, logLevel: level);
7474
}
7575

7676
/// <summary>
@@ -91,6 +91,6 @@ public static void ValidateNull<T>(this OperationResult<T> operationResult, obje
9191
if (value != null) return;
9292

9393
var errorMessage = $"{className}, {methodName} - The {propertyName} is null.";
94-
operationResult.AppendErrorMessage(errorMessage, logLevel: level);
94+
operationResult.AppendError(errorMessage, logLevel: level);
9595
}
9696
}

0 commit comments

Comments
 (0)