Wired up missing GiveAsync logic that would include recycling and giving to 'pocket'.

Author: Oren (electricessence)

source/ObjectPoolBase.cs

@@ -68,7 +68,8 @@ protected void OnGivenTo(bool wasGiven)
 
 		public void Give(T item)
 		{
-			if (PrepareToReceive(item) && (GaveToPocket(ref item) || Receive(item)))
+			if (PrepareToReceive(item)
+				&& (GaveToPocket(ref item) || Receive(item)))
 				OnGivenTo();
 		}
 
@@ -77,11 +78,19 @@ protected virtual Task<bool> GiveInternalAsync(T item)
 			return Task.Run(() => Receive(item));
 		}
 
-		public virtual Task GiveAsync(T item)
+		public Task GiveAsync(T item)
 		{
-			if (item == null) return Task.FromResult(false);
-			return GiveInternalAsync(item)
-				.ContinueWith(t => OnGivenTo(t.Result));
+			// We need to pre-check CanReceive because excessive tasks could build up if not.
+			if (item == null || !CanReceive) return Task.CompletedTask;
+			
+			return GiveAsyncConditional(item);
+		}
+
+		async Task GiveAsyncConditional(T item)
+		{
+			if(PrepareToReceive(item)
+				&& (GaveToPocket(ref item) || await GiveInternalAsync(item)))
+				OnGivenTo();
 		}
 
 		public virtual T Take()

source/Open.Disposable.ObjectPools.csproj

@@ -16,9 +16,10 @@ Part of the "Open" set of libraries.</Description>
     <RepositoryType>git</RepositoryType>
     <PackageTags>objectpool, dotnet, dotnetcore, cs, idisposable, threadsafe, thread-safe</PackageTags>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-    <Version>1.0.1</Version>
+    <Version>1.0.2</Version>
     <AssemblyVersion>1.1.0.0</AssemblyVersion>
     <FileVersion>1.1.0.0</FileVersion>
+    <PackageReleaseNotes>Wired up missing GiveAsync logic that would include recycling and giving to 'pocket'.</PackageReleaseNotes>
   </PropertyGroup>
 
   <ItemGroup>

tests/Open.Disposable.ObjectPools.Tests.csproj

@@ -6,9 +6,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
-    <PackageReference Include="MSTest.TestAdapter" Version="1.1.11" />
-    <PackageReference Include="MSTest.TestFramework" Version="1.1.11" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0-preview-20171012-09" />
+    <PackageReference Include="MSTest.TestAdapter" Version="1.2.0" />
+    <PackageReference Include="MSTest.TestFramework" Version="1.2.0" />
   </ItemGroup>
 
   <ItemGroup>