Non essential inspection and benchmark tuneup.

Author: Oren (electricessence)

benchmarking/Benchmark.cs

@@ -1,11 +1,16 @@
 using Open.Diagnostics;
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 
+#if DEBUG
+using System.Diagnostics;
+#endif
+
 namespace Open.Disposable.ObjectPools
 {
+	[SuppressMessage("ReSharper", "AccessToDisposedClosure")]
 	public class Benchmark<T> : BenchmarkBase<Func<IObjectPool<T>>>
 		where T : class
 	{
@@ -23,17 +28,20 @@ protected override IEnumerable<TimedResult> TestOnceInternal()
 		{
 			using (var pool = Param())
 			{
-
+				if (pool == null) throw new NullReferenceException();
 				//yield return TimedResult.Measure("Take From Empty (In Parallel)", () =>
 				//{
 				//	Parallel.For(0, TestSize, i => _items[i] = pool.Take());
 				//});
 
 				yield return TimedResult.Measure("Give To (In Parallel)", () =>
 				{
+					// ReSharper disable once AccessToDisposedClosure
 					Parallel.For(0, TestSize, i => pool.Give(_items[i]));
+#if DEBUG
 					var count = pool.Count;
 					Debug.Assert(pool is OptimisticArrayObjectPool<T> || count == TestSize, $"Expected {TestSize}, acutal count: {count}");
+#endif
 				});
 
 				yield return TimedResult.Measure("Mixed 90%-Take/10%-Give (In Parallel)", () =>

benchmarking/ConsoleReport.cs

@@ -4,11 +4,11 @@
 
 namespace Open.Disposable.ObjectPools
 {
-	public class ConsoleReport<T> : Open.Diagnostics.BenchmarkConsoleReport<Func<IObjectPool<T>>>
+	public class ConsoleReport<T> : Diagnostics.BenchmarkConsoleReport<Func<IObjectPool<T>>>
 		where T : class
 	{
 		const int ITERATIONS = 100000;
-		public ConsoleReport(TextWriter output = null) : base(ITERATIONS, output, (c, r, p) => Benchmark<T>.Results(c, r, p))
+		public ConsoleReport(TextWriter output = null) : base(ITERATIONS, output, Benchmark<T>.Results)
 		{
 		}
 

benchmarking/Program.cs

@@ -2,12 +2,14 @@
 using Open.Disposable.ObjectPools;
 using Open.Text.CSV;
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Text;
 
 class Program
 {
-	static void Main(string[] args)
+	[SuppressMessage("ReSharper", "CoVariantArrayConversion")]
+	static void Main()
 	{
 		Console.Write("Initializing...");
 

source/IObjectPool.cs

@@ -1,8 +1,10 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Open.Disposable
 {
+	[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 	public interface IObjectPool<T> : IDisposable
 		where T : class
 	{

tests/Open.Disposable.ObjectPools.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>    
-    <TargetFramework>netcoreapp2.0</TargetFramework>    
+    <TargetFramework>netcoreapp2.1</TargetFramework>    
     <RootNamespace>Open.Disposable</RootNamespace>
   </PropertyGroup>