Prep for update source publish.

Author: Oren (electricessence)

.editorconfig

@@ -0,0 +1,13 @@
+[*.cs]
+
+# CA1707: Identifiers should not contain underscores
+dotnet_diagnostic.CA1707.severity = silent
+
+# CA1303: Do not pass literals as localized parameters
+dotnet_diagnostic.CA1303.severity = silent
+
+# CA1051: Do not declare visible instance fields
+dotnet_diagnostic.CA1051.severity = silent
+
+# CA1034: Nested types should not be visible
+dotnet_diagnostic.CA1034.severity = silent

.github/workflows/main.yml

@@ -1,4 +1,7 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Diagnostics.Contracts;
 
 namespace Open.Hierarchy
 {
@@ -19,6 +22,7 @@ public interface IChild<out TParent> : IChild
 		new TParent? Parent { get; }
 	}
 
+	[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Null check properly implemented.")]
 	public static class ChildExtensions
 	{
 		/// <summary>
@@ -31,6 +35,7 @@ public static IEnumerable<TNode> GetAncestors<TNode>(
 			this TNode node)
 			where TNode : class, IChild<TNode>
 		{
+			if (node is null) throw new ArgumentNullException(nameof(node));
 			TNode? parent;
 			while ((parent = node.Parent) != null)
 			{
@@ -39,6 +44,7 @@ public static IEnumerable<TNode> GetAncestors<TNode>(
 			}
 		}
 
+
 		/// <summary>
 		/// Crawls the ancestor lineage returns the first node with no parent.
 		/// </summary>
@@ -49,6 +55,7 @@ public static TNode GetRoot<TNode>(
 			this TNode node)
 			where TNode : class, IChild<TNode>
 		{
+			if (node is null) throw new ArgumentNullException(nameof(node));
 			TNode? parent;
 			while ((parent = node.Parent) != null)
 			{

IChild.cs

@@ -62,7 +62,7 @@ public Node<T> GetNodeWithValue(T value, bool asUnmapped = false)
 #endif
 			public T Recycle(Node<T> node)
 			{
-				if (node == null) throw new ArgumentNullException(nameof(node));
+				if (node is null) throw new ArgumentNullException(nameof(node));
 				if (node._factory != this)
 					throw new ArgumentException("The node being provided for recycling does not belong to this factory.", nameof(node));
 				Contract.EndContractBlock();
@@ -77,7 +77,7 @@ internal T RecycleInternal(Node<T> n)
 			{
 				var value = n.Value;
 				var p = _pool;
-				if (p == null) n.Teardown();
+				if (p is null) n.Teardown();
 				else p.Give(n);
 				return value;
 			}
@@ -100,6 +100,7 @@ static void PrepareForPool(Node<T> n)
 			public Node<T> Map<TRoot>(TRoot root)
 				where TRoot : T
 			{
+				if (root is null) throw new ArgumentNullException(nameof(root));
 				var current = GetBlankNode();
 				current.Value = root;
 
@@ -125,8 +126,11 @@ public Node<T> Map<TRoot>(TRoot root)
 			/// <param name="container">The container of the root instance.</param>
 			/// <returns>The full map of the root.</returns>
 			public Node<T> Map<TRoot>(IHaveRoot<TRoot> container)
-				where TRoot : T => Map(container.Root);
-
+				where TRoot : T
+			{
+				if (container is null) throw new ArgumentNullException(nameof(container));
+				return Map(container.Root);
+			}
 		}
 
 	}

Node.Factory.cs

@@ -106,15 +106,15 @@ public int IndexOf(Node<T> child)
 
 		void AssertOkToJoinFamily(Node<T> child)
 		{
-			if (child.Parent == null) return;
+			if (child.Parent is null) return;
 			if (child.Parent == this)
 				throw new InvalidOperationException("Provided node already belongs to this parent.");
 			throw new InvalidOperationException("Provided node belongs to another parent.");
 		}
 
 		public void Insert(int index, Node<T> child)
 		{
-			if (child == null) throw new ArgumentNullException(nameof(child));
+			if (child is null) throw new ArgumentNullException(nameof(child));
 			Contract.EndContractBlock();
 
 			AssertNotRecycled();
@@ -156,7 +156,7 @@ public Node<T> this[int index]
 		/// <inheritdoc />
 		public bool Contains(Node<T> child)
 		{
-			if (child == null) throw new ArgumentNullException(nameof(child));
+			if (child is null) throw new ArgumentNullException(nameof(child));
 			Contract.EndContractBlock();
 
 			return _children.Contains(child);
@@ -165,7 +165,7 @@ public bool Contains(Node<T> child)
 		/// <inheritdoc />
 		public bool Remove(Node<T> child)
 		{
-			if (child == null) throw new ArgumentNullException(nameof(child));
+			if (child is null) throw new ArgumentNullException(nameof(child));
 			Contract.EndContractBlock();
 
 			if (!_children.Remove(child)) return false;
@@ -179,7 +179,7 @@ public bool Remove(Node<T> child)
 		/// <inheritdoc />
 		public void Add(Node<T> child)
 		{
-			if (child == null) throw new ArgumentNullException(nameof(child));
+			if (child is null) throw new ArgumentNullException(nameof(child));
 			Contract.EndContractBlock();
 
 			AssertNotRecycled();
@@ -240,8 +240,8 @@ public void AddValue(T value, bool asUnmapped = false)
 		/// <param name="replacement">The node to use as a replacement.</param>
 		public void Replace(Node<T> node, Node<T> replacement)
 		{
-			if (node == null) throw new ArgumentNullException(nameof(node));
-			if (replacement == null) throw new ArgumentNullException(nameof(replacement));
+			if (node is null) throw new ArgumentNullException(nameof(node));
+			if (replacement is null) throw new ArgumentNullException(nameof(replacement));
 			Contract.EndContractBlock();
 
 			if (replacement.Parent != null)

Node.cs

@@ -2,35 +2,32 @@
 
 	<PropertyGroup>
 		<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
+		<LangVersion>latest</LangVersion>
+		<Nullable>enable</Nullable>
 		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
 		<Authors>electricessence</Authors>
-		<Company>electricessence</Company>
-		<Description>
-			Interfaces and classes helful in managing tree-like data structures.
-
-			Part of the "Open" set of libraries.
-		</Description>
-		<Copyright>https://github.com/electricessence/Open.Hierarchy/blob/master/LICENSE</Copyright>
-		<PackageLicenseUrl></PackageLicenseUrl>
-		<PackageProjectUrl>https://github.com/electricessence/Open.Hierarchy/</PackageProjectUrl>
-		<RepositoryUrl>https://github.com/electricessence/Open.Hierarchy/</RepositoryUrl>
+		<Description>Interfaces and classes helful in managing tree-like data structures.
+
+Part of the "Open" set of libraries.
+</Description>
+		<Copyright>https://github.com/Open-NET-Libraries/Open.Hierarchy/blob/master/LICENSE</Copyright>
+		<PackageProjectUrl>https://github.com/Open-NET-Libraries/Open.Hierarchy/</PackageProjectUrl>
+		<RepositoryUrl>https://github.com/Open-NET-Libraries/Open.Hierarchy/</RepositoryUrl>
 		<RepositoryType>git</RepositoryType>
 		<PackageTags>dotnet, dotnetcore, cs, tree, node, hierarchy, parent, child, root</PackageTags>
-		<Version>1.7.2</Version>
+		<Version>1.7.3</Version>
 		<PackageReleaseNotes></PackageReleaseNotes>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
-		<Nullable>enable</Nullable>
-	
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
-  </PropertyGroup>
+    <PackageIcon>logo.png</PackageIcon>
+	</PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
   </ItemGroup>
 
-
 	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
 		<LangVersion>latest</LangVersion>
 	</PropertyGroup>
@@ -40,13 +37,27 @@
 	</PropertyGroup>
 
 	<ItemGroup>
+		<None Remove=".editorconfig" />
 		<None Remove=".git" />
 		<None Remove=".gitignore" />
 		<None Remove="LICENSE" />
+		<None Remove="Readme.md" />
+		<None Include="logo.png">
+		  <Pack>True</Pack>
+		  <PackagePath></PackagePath>
+		</None>
+	</ItemGroup>
+
+	<ItemGroup>
+	  <AdditionalFiles Include=".editorconfig" />
 	</ItemGroup>
 
 	<ItemGroup>
 		<PackageReference Include="Open.Disposable.ObjectPools" Version="2.4.1" />
+		<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
 	</ItemGroup>
 
 </Project>

Open.Hierarchy.csproj

@@ -1,6 +1,7 @@
 # Open.Hierarchy
 
-![.NET Core](https://github.com/Open-NET-Libraries/Open.Hierarchy/workflows/.NET%20Core/badge.svg) [![NuGet](http://img.shields.io/nuget/v/Open.Hierarchy.svg)](https://www.nuget.org/packages/Open.Hierarchy/)
+![.NET Core](https://github.com/Open-NET-Libraries/Open.Hierarchy/workflows/.NET%20Core/badge.svg)
+[![NuGet](https://img.shields.io/nuget/v/Open.Hierarchy.svg)](https://www.nuget.org/packages/Open.Hierarchy/)
 
 ## `Node<T>`
 

Readme.md

@@ -67,6 +67,8 @@ public static IEnumerable<TNode> GetNodesOfType<TNode>(
 		public static IEnumerable<object> GetDescendants(
 			this IParent root, TraversalMode traversal = TraversalMode.BreadthFirst)
 		{
+			if (root is null) throw new ArgumentNullException(nameof(root));
+
 			// Attempt to be more breadth first.
 			switch (traversal)
 			{