Improved use of Interlocked.Exchange for .Cancel

electricessence · web-flow · commit 763b1daaf0e4 · 2018-05-02T12:41:06.000-07:00
diff --git a/ActionRunner.cs b/ActionRunner.cs
@@ -71,8 +71,9 @@ public Exception LastFault
 		public bool Cancel(bool onlyIfNotRunning)
 		{
 			var t = _task;
-			return t?.Cancel(onlyIfNotRunning) ?? false
-				&& t == Interlocked.CompareExchange(ref _task, null, t);
+			return t!=null
+				&& t == Interlocked.CompareExchange(ref _task, null, t)
+				&& t.Cancel(onlyIfNotRunning);
 		}
 
 		public bool Cancel()

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,9 @@ public Exception LastFault`
`71`	`71`	`public bool Cancel(bool onlyIfNotRunning)`
`72`	`72`	`{`
`73`	`73`	`var t = _task;`
`74`		`- return t?.Cancel(onlyIfNotRunning) ?? false`
`75`		`- && t == Interlocked.CompareExchange(ref _task, null, t);`
	`74`	`+ return t!=null`
	`75`	`+ && t == Interlocked.CompareExchange(ref _task, null, t)`
	`76`	`+ && t.Cancel(onlyIfNotRunning);`
`76`	`77`	`}`
`77`	`78`
`78`	`79`	`public bool Cancel()`