git subrepo pull (merge) ore

subrepo:
  subdir:   "ore"
  merged:   "684e540572"
upstream:
  origin:   "git@gitlab.acadiasoft.net:qs/ore.git"
  branch:   "master"
  commit:   "127314a796"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "73a0129"

Author: jenkins

OREData/ored/portfolio/legdata.cpp

@@ -1649,7 +1649,7 @@ Leg makeCPILeg(const LegData& data, const boost::shared_ptr<ZeroInflationIndex>&
     CPI::InterpolationType interpolationMethod;
     if (cpiLegData->interpolation().empty()) {
         QL_REQUIRE(cpiSwapConvention,
-                   "observationLag is not specified in legData and couldn't find convention for "
+                   "Interpolation is not specified in legData and couldn't find convention for "
                        << cpiLegData->index() << ". Please add field to trade xml or add convention");
         DLOG("Build CPI Leg and use observation lag from standard inflationswap convention");
         interpolationMethod = cpiSwapConvention->interpolated() ? CPI::Linear : CPI::Flat;

QuantExt/qle/pricingengines/numericalintegrationindexcdsoptionengine.cpp

@@ -223,13 +223,19 @@ void NumericalIntegrationIndexCdsOptionEngine::doCalc() const {
         };
 
         Real fepAdjustedForwardSpread;
-        Brent brent;
-        brent.setLowerBound(1.0E-8);
-        try {
-            fepAdjustedForwardSpread = brent.solve(target, 1.0E-7, arguments_.swap->fairSpreadClean(), 0.0001);
-        } catch (const std::exception& e) {
-            QL_FAIL(
-                "NumericalIntegrationIndexCdsOptionEngine::doCalc(): failed to calibrate forward spread: " << e.what());
+        if (target(0.0) > 0.0) {
+            // the target function might not have a zero, because of the continuous annuity approximation
+            // in some extreme situations (e.g. survival prob = 1 everywhere)
+            fepAdjustedForwardSpread = 0.0;
+        } else {
+            Brent brent;
+            brent.setLowerBound(0.0);
+            try {
+                fepAdjustedForwardSpread = brent.solve(target, 1.0E-7, arguments_.swap->fairSpreadClean(), 0.0001);
+            } catch (const std::exception& e) {
+                QL_FAIL("NumericalIntegrationIndexCdsOptionEngine::doCalc(): failed to calibrate forward spread: "
+                        << e.what());
+            }
         }
         results_.additionalResults["fepAdjustedForwardSpread"] = fepAdjustedForwardSpread;
         results_.additionalResults["forwardSpread"] = arguments_.swap->fairSpreadClean();