QPR-12253 MR comments

Author: hsegger

Examples/Example_40/Input/ore.xml

@@ -81,7 +81,7 @@
       <Parameter name="sensitivityOutputFile">sensitivity.csv</Parameter>
       <Parameter name="outputSensitivityThreshold">0.000001</Parameter>
       <Parameter name="parSensitivity">Y</Parameter>
-			<Parameter name="optimiseRiskFactors">Y</Parameter>
+      <Parameter name="optimiseRiskFactors">Y</Parameter>
       <Parameter name="parSensitivityOutputFile">parsensitivity.csv</Parameter>
       <Parameter name="outputJacobi">Y</Parameter>
       <Parameter name="jacobiOutputFile">jacobi.csv</Parameter>

OREAnalytics/orea/app/analytics/pricinganalytic.cpp

@@ -237,8 +237,8 @@ void PricingAnalyticImpl::runAnalytic(
 
                 if (inputs_->optimiseRiskFactors()){
                     std::set<RiskFactorKey> collectRiskFactors;
-                    //collect risk factors of all cubes and ...
-                    for(auto& c : sensiAnalysis->sensiCubes()){
+                    // collect risk factors of all cubes ...
+                    for(auto const& c : sensiAnalysis->sensiCubes()){
                         auto currentRF = c->relevantRiskFactors();
                         // ... and combine for the par analysis
                         collectRiskFactors.insert(currentRF.begin(), currentRF.end());