Skip to content

Commit 2073438

Browse files
committed
Merge remote-tracking branch 'model-validation/remove-joint-calendar' into gh_206_210
2 parents cfe78ce + 8c818c5 commit 2073438

8 files changed

Lines changed: 13 additions & 175 deletions

File tree

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[submodule "QuantLib"]
22
path = QuantLib
3-
url = git@gitlab.acadiasoft.net:qs/quantlib.git
3+
url = https://github.com/OpenSourceRisk/QuantLib.git
44
branch = master
55
ignore = dirty

OREData/ored/utilities/calendarparser.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
#include <qle/calendars/ireland.hpp>
3636
#include <qle/calendars/islamicweekendsonly.hpp>
3737
#include <qle/calendars/israel.hpp>
38-
#include <qle/calendars/largejointcalendar.hpp>
3938
#include <qle/calendars/luxembourg.hpp>
4039
#include <qle/calendars/malaysia.hpp>
4140
#include <qle/calendars/mauritius.hpp>
@@ -88,7 +87,7 @@ QuantLib::Calendar CalendarParser::parseCalendar(const std::string& name) const
8887
QL_FAIL("Cannot convert \"" << name << "\" to Calendar [unhandled exception]");
8988
}
9089
}
91-
return QuantExt::LargeJointCalendar(calendars);
90+
return QuantLib::JointCalendar(calendars);
9291
}
9392
}
9493

OREData/test/parser.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
#include <ql/time/calendars/austria.hpp>
2828
#include <ql/time/calendars/chile.hpp>
2929
#include <ql/time/calendars/france.hpp>
30+
#include <ql/time/calendars/jointcalendar.hpp>
3031
#include <ql/time/calendars/thailand.hpp>
3132
#include <ql/time/daycounters/all.hpp>
3233
#include <qle/calendars/colombia.hpp>
3334
#include <qle/calendars/israel.hpp>
34-
#include <qle/calendars/largejointcalendar.hpp>
3535
#include <qle/calendars/malaysia.hpp>
3636
#include <qle/calendars/netherlands.hpp>
3737
#include <qle/calendars/peru.hpp>
@@ -927,7 +927,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
927927
Calendar peru = QuantExt::Peru();
928928

929929
cals.push_back(peru);
930-
Calendar joint1 = QuantExt::LargeJointCalendar(cals);
930+
Calendar joint1 = QuantLib::JointCalendar(cals);
931931

932932
std::vector<Date> hol = joint1.holidayList(Date(1, January, 2018), Date(31, December, 2018));
933933
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -955,7 +955,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
955955

956956
Calendar col = Colombia();
957957
cals.push_back(col);
958-
Calendar joint2 = QuantExt::LargeJointCalendar(cals);
958+
Calendar joint2 = QuantLib::JointCalendar(cals);
959959

960960
hol = joint2.holidayList(Date(1, January, 2018), Date(31, December, 2018));
961961
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -978,7 +978,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
978978

979979
Calendar phil = Philippines();
980980
cals.push_back(phil);
981-
Calendar joint3 = QuantExt::LargeJointCalendar(cals);
981+
Calendar joint3 = QuantLib::JointCalendar(cals);
982982

983983
hol = joint3.holidayList(Date(1, January, 2018), Date(31, December, 2018));
984984
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -1004,7 +1004,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
10041004

10051005
Calendar thai = Thailand();
10061006
cals.push_back(thai);
1007-
Calendar joint4 = QuantExt::LargeJointCalendar(cals);
1007+
Calendar joint4 = QuantLib::JointCalendar(cals);
10081008

10091009
hol = joint4.holidayList(Date(1, January, 2018), Date(31, December, 2018));
10101010
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -1020,7 +1020,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
10201020

10211021
Calendar mal = Malaysia();
10221022
cals.push_back(mal);
1023-
Calendar joint5 = QuantExt::LargeJointCalendar(cals);
1023+
Calendar joint5 = QuantLib::JointCalendar(cals);
10241024

10251025
hol = joint5.holidayList(Date(1, January, 2018), Date(31, December, 2018));
10261026
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -1044,7 +1044,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
10441044

10451045
Calendar chil = Chile();
10461046
cals.push_back(chil);
1047-
Calendar joint6 = QuantExt::LargeJointCalendar(cals);
1047+
Calendar joint6 = QuantLib::JointCalendar(cals);
10481048

10491049
hol = joint6.holidayList(Date(1, January, 2018), Date(31, December, 2018));
10501050
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -1062,7 +1062,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
10621062

10631063
Calendar net = Netherlands();
10641064
cals.push_back(net);
1065-
Calendar joint7 = QuantExt::LargeJointCalendar(cals);
1065+
Calendar joint7 = QuantLib::JointCalendar(cals);
10661066

10671067
hol = joint7.holidayList(Date(1, January, 2018), Date(31, December, 2018));
10681068
BOOST_CHECK(hol.size() == expectedHolidays.size());
@@ -1083,7 +1083,7 @@ BOOST_AUTO_TEST_CASE(testJointCalendar) {
10831083

10841084
Calendar fre = France();
10851085
cals.push_back(fre);
1086-
Calendar joint8 = QuantExt::LargeJointCalendar(cals);
1086+
Calendar joint8 = QuantLib::JointCalendar(cals);
10871087

10881088
hol = joint8.holidayList(Date(1, January, 2018), Date(31, December, 2018));
10891089
BOOST_CHECK(hol.size() == expectedHolidays.size());

QuantExt/qle/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ calendars/ice.cpp
1515
calendars/ireland.cpp
1616
calendars/islamicweekendsonly.cpp
1717
calendars/israel.cpp
18-
calendars/largejointcalendar.cpp
1918
calendars/luxembourg.cpp
2019
calendars/malaysia.cpp
2120
calendars/mauritius.cpp
@@ -413,7 +412,6 @@ calendars/ice.hpp
413412
calendars/ireland.hpp
414413
calendars/islamicweekendsonly.hpp
415414
calendars/israel.hpp
416-
calendars/largejointcalendar.hpp
417415
calendars/luxembourg.hpp
418416
calendars/malaysia.hpp
419417
calendars/mauritius.hpp

QuantExt/qle/calendars/largejointcalendar.cpp

Lines changed: 0 additions & 97 deletions
This file was deleted.

QuantExt/qle/calendars/largejointcalendar.hpp

Lines changed: 0 additions & 61 deletions
This file was deleted.

QuantExt/qle/indexes/compositeindex.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818

1919
#include <qle/indexes/compositeindex.hpp>
2020

21-
#include <qle/calendars/largejointcalendar.hpp>
2221
#include <qle/indexes/bondindex.hpp>
2322
#include <qle/indexes/equityindex.hpp>
2423
#include <qle/indexes/genericindex.hpp>
24+
#include <ql/time/calendars/jointcalendar.hpp>
2525

2626
namespace QuantExt {
2727

@@ -46,7 +46,7 @@ CompositeIndex::CompositeIndex(const std::string& name, const std::vector<boost:
4646
cals.push_back(i->fixingCalendar());
4747
}
4848

49-
fixingCalendar_ = LargeJointCalendar(cals);
49+
fixingCalendar_ = JointCalendar(cals);
5050
}
5151

5252
std::string CompositeIndex::name() const { return name_; }

QuantExt/qle/quantext.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include <qle/calendars/ireland.hpp>
2424
#include <qle/calendars/islamicweekendsonly.hpp>
2525
#include <qle/calendars/israel.hpp>
26-
#include <qle/calendars/largejointcalendar.hpp>
2726
#include <qle/calendars/luxembourg.hpp>
2827
#include <qle/calendars/malaysia.hpp>
2928
#include <qle/calendars/mauritius.hpp>

0 commit comments

Comments
 (0)