QPR-12190 -- Fix AMCValuationEngine progress logging. progress numbers were doubled because updateProgress was being called twice, and total number does not need the +1.

Author: NathanielVolfango

OREAnalytics/orea/engine/amcvaluationengine.cpp

@@ -145,7 +145,7 @@ void runCoreEngine(const boost::shared_ptr<ore::data::Portfolio>& portfolio,
                    const Size aggDataNumberCreditStates, boost::shared_ptr<ore::analytics::AggregationScenarioData> asd,
                    boost::shared_ptr<NPVCube> outputCube, boost::shared_ptr<ProgressIndicator> progressIndicator) {
 
-    progressIndicator->updateProgress(0, portfolio->size() + 1);
+    progressIndicator->updateProgress(0, portfolio->size());
 
     // base currency is the base currency of the cam
 
@@ -297,7 +297,6 @@ void runCoreEngine(const boost::shared_ptr<ore::data::Portfolio>& portfolio,
         } catch (const std::exception& e) {
             StructuredTradeErrorMessage(trade.second, "Error building trade for AMC simulation", e.what()).log();
         }
-        progressIndicator->updateProgress(++progressCounter, portfolio->size() + 1);
     }
 
     timer.stop();
@@ -548,7 +547,7 @@ void runCoreEngine(const boost::shared_ptr<ore::data::Portfolio>& portfolio,
                 }
             }
         }
-        progressIndicator->updateProgress(++progressCounter, portfolio->size() + 1);
+        progressIndicator->updateProgress(++progressCounter, portfolio->size());
     }
     timer.stop();
     valuationTime += timer.elapsed().wall * 1e-9;