Skip to content

Commit 31d7afe

Browse files
pcaspersjenkins
authored andcommitted
QPR-12014 next try to fix xml diff
1 parent af279d8 commit 31d7afe

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

Tools/PythonTools/compare_files.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -555,12 +555,12 @@ def compare_files_direct(name, file_1, file_2):
555555
def compare_files_xml(name, file_1, file_2):
556556
logger = logging.getLogger(__name__)
557557
logger.debug('%s: Comparing file %s against %s using xml diff', name, file_1, file_2)
558-
diff = main.diff_files(file_1, file_2)
559-
match = True
560-
for line in diff:
561-
match = False
562-
logger.warning(line)
563-
return match
558+
diff = main.diff_files(file_1, file_2, formatter=formatting.DiffFormatter())
559+
if len(diff) > 0:
560+
logger.warning(diff)
561+
return False
562+
else:
563+
return True
564564

565565
def compare_files_json(name, file_1, file_2, config) -> bool:
566566
# Compare JSON files using configuration.

0 commit comments

Comments
 (0)