QPR-11984 replace memcpy with copy

Author: pcaspers

QuantExt/qle/math/randomvariable.cpp

@@ -37,7 +37,8 @@ Filter::Filter(const Filter& r) {
     constantData_ = r.constantData_;
     if (r.data_) {
         data_ = new bool[n_];
-        std::memcpy(data_, r.data_, n_ * sizeof(bool));
+        // std::memcpy(data_, r.data_, n_ * sizeof(bool));
+        std::copy(r.data_, r.data_ + n_, data_);
     } else {
         data_ = nullptr;
     }
@@ -67,7 +68,8 @@ Filter& Filter::operator=(const Filter& r) {
                     delete[] data_;
                 data_ = new bool[r.n_];
             }
-            std::memcpy(data_, r.data_, r.n_ * sizeof(bool));
+            // std::memcpy(data_, r.data_, r.n_ * sizeof(bool));
+            std::copy(r.data_, r.data_ + r.n_, data_);
         } else {
             if (data_) {
                 delete[] data_;
@@ -253,7 +255,8 @@ RandomVariable::RandomVariable(const RandomVariable& r) {
     constantData_ = r.constantData_;
     if (r.data_) {
         data_ = new double[n_];
-        std::memcpy(data_, r.data_, n_ * sizeof(double));
+        // std::memcpy(data_, r.data_, n_ * sizeof(double));
+        std::copy(r.data_, r.data_ + n_, data_);
     } else {
         data_ = nullptr;
     }
@@ -285,7 +288,8 @@ RandomVariable& RandomVariable::operator=(const RandomVariable& r) {
                     delete[] data_;
                 data_ = new double[r.n_];
             }
-            std::memcpy(data_, r.data_, r.n_ * sizeof(double));
+            // std::memcpy(data_, r.data_, r.n_ * sizeof(double));
+            std::copy(r.data_, r.data_ + r.n_, data_);
         } else {
             if (data_) {
                 delete[] data_;
@@ -341,7 +345,8 @@ RandomVariable::RandomVariable(const QuantLib::Array& array, const Real time) {
     time_ = time;
     if (n_ != 0) {
         data_ = new double[n_];
-        std::memcpy(data_, array.begin(), n_ * sizeof(double));
+        // std::memcpy(data_, array.begin(), n_ * sizeof(double));
+        std::copy(array.begin(),array.end(), data_);
     } else {
         data_ = nullptr;
     }
@@ -360,7 +365,8 @@ void RandomVariable::copyToArray(QuantLib::Array& array) const {
     if (deterministic_)
         std::fill(array.begin(), array.end(), constantData_);
     else if (n_ != 0) {
-        std::memcpy(array.begin(), data_, n_ * sizeof(double));
+        // std::memcpy(array.begin(), data_, n_ * sizeof(double));
+        std::copy(array.begin(),array.end(), data_);
     }
 }