QPR-12275 replace method returning reference by set method

Author: pcaspers

OREData/ored/portfolio/trade.cpp

@@ -119,6 +119,10 @@ void Trade::validate() const {
     }
 }
 
+void Trade::setEnvelope(const Envelope& envelope) {
+    envelope_ = envelope;
+}
+
 void Trade::reset() {
     // save accumulated timings from wrapper to trade before resetting
     if (instrument_ != nullptr) {

OREData/ored/portfolio/trade.hpp

@@ -118,7 +118,7 @@ class Trade : public XMLSerializable {
     string& id() { return id_; }
 
     //! Set the envelope with counterparty and portfolio info
-    Envelope& envelope() { return envelope_; }
+    void setEnvelope(const Envelope& envelope);
 
     //! Set the trade actions
     TradeActions& tradeActions() { return tradeActions_; }